Skip to content

Correct link to egghead course on making contributions in github#1974

Merged
brownsarahm merged 1 commit into
carpentries:mainfrom
finnshort:update-egghead-contributing-link
Feb 5, 2026
Merged

Correct link to egghead course on making contributions in github#1974
brownsarahm merged 1 commit into
carpentries:mainfrom
finnshort:update-egghead-contributing-link

Conversation

@finnshort

Copy link
Copy Markdown

The link to the egghead course "How to Contribute to an Open Source Project on GitHub" gives a 404 error.

This PR replaces it with the current link ('courses' instead of 'series').

@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/instructor-training/compare/md-outputs..md-outputs-PR-1974

The following changes were observed in the rendered markdown documents:


What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2026-02-05 19:41:41 +0000

@brownsarahm brownsarahm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @finnshort !

github-actions Bot pushed a commit that referenced this pull request Feb 5, 2026
@finnshort

Copy link
Copy Markdown
Author

Thanks @brownsarahm! I didn't see anything in the 'contributing.md' about merging and deploying- once approved do I go ahead and merge? Does someone else deploy (or does it happen automatically through github pages)?

@brownsarahm

Copy link
Copy Markdown
Member

You shouldn't have permission to merge? I was just waiting for the checks to run in case there was a typo my eyes missed that broke something, but it looks good now and ill merge.

@brownsarahm
brownsarahm merged commit 54ae636 into carpentries:main Feb 5, 2026
5 checks passed
@finnshort

Copy link
Copy Markdown
Author

Oh yes that makes sense. Okay thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants