Don't store _old_ if we're passed nil#175
Conversation
|
Sorry for the awful delay here. Thanks to #179, and after a hiatus, I'm now in the process of catching up with things on this project. If this issue is still a problem, could you please rebase on master to get the test suite green for this PR? |
2070faa to
84b8e16
Compare
|
@rmm5t No worries! I rebased off master, but I'm not sure if this change is still necessary. Will try to play around some more to see. |
|
Hello there. We're facing this exact issue so I think this change is still necessary 🙂 |
|
That being said, testing this PR in a custom fork it seems that it should be |
|
@artfuldodger @simonc Sorry for the long delay with this PR. Would someone be willing to investigate this further while also adding a spec to confirm behavior? |
|
I'm not using Mongo any more, so I'm of no use here |
Saying, for example
user.update(avatar: nil)will result with theavatar_filenameset to "old", which is unexpected.