Final improvements: better variable naming, commit message, and robust file checking

Co-authored-by: carstenartur <3164220+carstenartur@users.noreply.github.com>

Author: Copilot

.github/workflows/sync-upstream.yml

@@ -38,11 +38,11 @@ jobs:
           # Create temporary directory for fork-specific files
           mkdir -p /tmp/fork-specific
           
-          # Get list of all files in fork (filtering for fork-specific happens in the loop)
-          ALL_FILES=$(git ls-tree -r HEAD --name-only 2>/dev/null || echo "")
+          # Get list of all files in current branch
+          FILES_TO_CHECK=$(git ls-tree -r HEAD --name-only 2>/dev/null || echo "")
           
-          # For each file in fork, check if it exists in upstream
-          for file in $ALL_FILES; do
+          # For each file in fork, check if it exists in upstream (files that don't = fork-specific)
+          for file in $FILES_TO_CHECK; do
             if ! git cat-file -e upstream/master:"$file" 2>/dev/null; then
               echo "Fork-specific file: $file"
               # Create directory structure and copy file
@@ -52,7 +52,7 @@ jobs:
           done
           
           # Check if any fork-specific files were found
-          if [ -d "/tmp/fork-specific" ] && [ -n "$(find /tmp/fork-specific -type f)" ]; then
+          if [ -d "/tmp/fork-specific" ] && find /tmp/fork-specific -type f -print -quit | grep -q .; then
             echo "has_fork_files=true" >> $GITHUB_OUTPUT
             echo "Found fork-specific files:"
             find /tmp/fork-specific -type f
@@ -95,9 +95,7 @@ jobs:
 
   sync-manual:
     name: Sync Fork (Manual)
-    if: |
-      github.event_name == 'issue_comment' &&
-      contains(github.event.comment.body, '/sync-upstream')
+    if: contains(github.event.comment.body, '/sync-upstream')
     runs-on: ubuntu-latest
     permissions:
       contents: write
@@ -175,11 +173,11 @@ jobs:
           # Create temporary directory for fork-specific files
           mkdir -p /tmp/fork-specific
           
-          # Get list of all files in fork (filtering for fork-specific happens in the loop)
-          ALL_FILES=$(git ls-tree -r HEAD --name-only 2>/dev/null || echo "")
+          # Get list of all files in current branch
+          FILES_TO_CHECK=$(git ls-tree -r HEAD --name-only 2>/dev/null || echo "")
           
-          # For each file in fork, check if it exists in upstream
-          for file in $ALL_FILES; do
+          # For each file in fork, check if it exists in upstream (files that don't = fork-specific)
+          for file in $FILES_TO_CHECK; do
             if ! git cat-file -e upstream/master:"$file" 2>/dev/null; then
               echo "Fork-specific file: $file"
               # Create directory structure and copy file
@@ -189,7 +187,7 @@ jobs:
           done
           
           # Check if any fork-specific files were found
-          if [ -d "/tmp/fork-specific" ] && [ -n "$(find /tmp/fork-specific -type f)" ]; then
+          if [ -d "/tmp/fork-specific" ] && find /tmp/fork-specific -type f -print -quit | grep -q .; then
             echo "has_fork_files=true" >> $GITHUB_OUTPUT
             echo "Found fork-specific files:"
             find /tmp/fork-specific -type f
@@ -221,7 +219,7 @@ jobs:
         run: |
           # Check if there are changes to commit
           if ! git diff --cached --quiet; then
-            git commit -m "Fork-specific CI and workflow configurations"
+            git commit -m "Fork-specific customizations"
             echo "✅ Fork-specific changes committed"
           else
             echo "ℹ️  No fork-specific changes to commit"