refactor: replace local isPrivateProperty with the implementation in eslint-etc

Author: NachoVazquez

package.json

@@ -6,7 +6,7 @@
   "dependencies": {
     "@typescript-eslint/experimental-utils": "^5.0.0",
     "common-tags": "^1.8.0",
-    "eslint-etc": "^5.0.0",
+    "eslint-etc": "^5.2.0",
     "requireindex": "~1.2.0",
     "tslib": "^2.0.0"
   },

source/rules/prefer-composition.ts

@@ -11,10 +11,11 @@ import {
   isAssignmentExpression,
   isCallExpression,
   isIdentifier,
+  isPrivateIdentifier,
   isMemberExpression,
   isVariableDeclarator,
 } from "eslint-etc";
-import { ruleCreator, isPrivateIdentifier } from "../utils";
+import { ruleCreator } from "../utils";
 
 const defaultOptions: readonly {
   checkDecorators?: string[];

source/utils.ts

@@ -4,16 +4,8 @@
  */
 
 import { ESLintUtils } from "@typescript-eslint/experimental-utils";
-import { TSESTree as es } from "@typescript-eslint/experimental-utils";
 
 export const ruleCreator = ESLintUtils.RuleCreator(
   (name) =>
     `https://github.com/cartant/eslint-plugin-rxjs-angular/tree/main/docs/rules/${name}.md`
 );
-
-// TODO: Remove when eslint-etc supports isPrivateIdentifier
-export function isPrivateIdentifier(
-  node: es.Node
-): node is es.PrivateIdentifier {
-  return node.type === "PrivateIdentifier";
-}

yarn.lock

@@ -712,14 +712,14 @@ escape-string-regexp@^1.0.5:
   resolved "https://registry.yarnpkg.com/escape-string-regexp/-/escape-string-regexp-1.0.5.tgz#1b61c0562190a8dff6ae3bb2cf0200ca130b86d4"
   integrity sha1-G2HAViGQqN/2rjuyzwIAyhMLhtQ=
 
-eslint-etc@^5.0.0:
-  version "5.0.1"
-  resolved "https://registry.yarnpkg.com/eslint-etc/-/eslint-etc-5.0.1.tgz#c2caa5993cafb82fd6b57994a0ad231d7b0fe207"
-  integrity sha512-QfRKA46LdQTOT7T0rwZJJ2kirGJSP49GgyrtxRMaFF+m04efkqDYxfrhImpP1a/gh/XQzfWBvbU2Qr2vLJk4wQ==
+eslint-etc@^5.2.0:
+  version "5.2.0"
+  resolved "https://registry.yarnpkg.com/eslint-etc/-/eslint-etc-5.2.0.tgz#c51c19a2ffb6447af76a1c5ffd13b9a212db859b"
+  integrity sha512-Gcm/NMa349FOXb1PEEfNMMyIANuorIc2/mI5Vfu1zENNsz+FBVhF62uY6gPUCigm/xDOc8JOnl+71WGnlzlDag==
   dependencies:
     "@typescript-eslint/experimental-utils" "^5.0.0"
     tsutils "^3.17.1"
-    tsutils-etc "^1.3.4"
+    tsutils-etc "^1.4.1"
 
 eslint-import-resolver-node@^0.3.6:
   version "0.3.6"
@@ -2056,10 +2056,10 @@ tslib@^2.0.0:
   resolved "https://registry.yarnpkg.com/tslib/-/tslib-2.3.1.tgz#e8a335add5ceae51aa261d32a490158ef042ef01"
   integrity sha512-77EbyPPpMz+FRFRuAFlWMtmgUWGe9UOG2Z25NqCwiIjRhOf5iKGuzSe5P2w1laq+FkRy4p+PCuVkJSGkzTEKVw==
 
-tsutils-etc@^1.3.4:
-  version "1.3.4"
-  resolved "https://registry.yarnpkg.com/tsutils-etc/-/tsutils-etc-1.3.4.tgz#35def32592fe16f56bb5f0bdc9844acdad6c9bab"
-  integrity sha512-GOQJeZgE0rFiok0CsOrvNgLrIG5LiVEYtSiPHZz0KFFlSR8q3qXMkGZ3hOvFpBvB++B7PVEMhjQQmAF3tSFLKA==
+tsutils-etc@^1.4.1:
+  version "1.4.1"
+  resolved "https://registry.yarnpkg.com/tsutils-etc/-/tsutils-etc-1.4.1.tgz#bd42a0079d534765ab314d087f8a89c77a68723f"
+  integrity sha512-6UPYgc7OXcIW5tFxlsZF3OVSBvDInl/BkS3Xsu64YITXk7WrnWTVByKWPCThFDBp5gl5IGHOzGMdQuDCE7OL4g==
   dependencies:
     "@types/yargs" "^17.0.0"
     yargs "^17.0.0"