Skip to content

fix: allow prefer-takeuntil and prefer-composition rules to support p…#12

Open
NachoVazquez wants to merge 2 commits into
cartant:mainfrom
NachoVazquez:fix/11/support-js-private-variables-in-rules
Open

fix: allow prefer-takeuntil and prefer-composition rules to support p…#12
NachoVazquez wants to merge 2 commits into
cartant:mainfrom
NachoVazquez:fix/11/support-js-private-variables-in-rules

Conversation

@NachoVazquez
Copy link
Copy Markdown

The Problem:

Fixes: #11

Previous Behavior

Javascript private variables like #subscription were not supported for prefer-takeuntil and prefer-composition rules

Current Behavior

It allows for the prefer-takeuntil and prefer-composition rules to use Javascript private variables.

Comment thread source/utils.ts Outdated
Comment thread source/utils.ts Outdated
@NachoVazquez NachoVazquez force-pushed the fix/11/support-js-private-variables-in-rules branch from 3083f05 to 44cc98d Compare November 7, 2022 13:55
@NachoVazquez NachoVazquez requested review from LayZeeDK and Michsior14 and removed request for LayZeeDK November 7, 2022 13:56
@JasonWeinzierl
Copy link
Copy Markdown

You could open a PR under fork https://github.com/JasonWeinzierl/eslint-plugin-rxjs-angular-x .

@NachoVazquez
Copy link
Copy Markdown
Author

You could open a PR under fork JasonWeinzierl/eslint-plugin-rxjs-angular-x.

Hey @JasonWeinzierl, that's a sure thing! Are you working with @ktrz and the ClickUp folks? I know they were also discussing creating a fork.

@JasonWeinzierl
Copy link
Copy Markdown

You could open a PR under fork JasonWeinzierl/eslint-plugin-rxjs-angular-x.

Hey @JasonWeinzierl, that's a sure thing! Are you working with @ktrz and the ClickUp folks? I know they were also discussing creating a fork.

Oop I haven't heard from them, thank you! I've been following discussions here: angular-eslint/angular-eslint#2094 and here: ReactiveX/rxjs#7492 , as well as issues on this repo itself. Is there anywhere else discussions are happening?

@NachoVazquez
Copy link
Copy Markdown
Author

You could open a PR under fork JasonWeinzierl/eslint-plugin-rxjs-angular-x.

Hey @JasonWeinzierl, that's a sure thing! Are you working with @ktrz and the ClickUp folks? I know they were also discussing creating a fork.

Oop I haven't heard from them, thank you! I've been following discussions here: angular-eslint/angular-eslint#2094 and here: ReactiveX/rxjs#7492 , as well as issues on this repo itself. Is there anywhere else discussions are happening?

It is probably in closed conversations for now. But I'm happy to contribute to your work while the ecosystem aligns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support es2022 private properties in prefer-takeuntil

4 participants