fix: allow prefer-takeuntil and prefer-composition rules to support p…#12
fix: allow prefer-takeuntil and prefer-composition rules to support p…#12NachoVazquez wants to merge 2 commits into
Conversation
3083f05 to
44cc98d
Compare
|
You could open a PR under fork https://github.com/JasonWeinzierl/eslint-plugin-rxjs-angular-x . |
Hey @JasonWeinzierl, that's a sure thing! Are you working with @ktrz and the ClickUp folks? I know they were also discussing creating a fork. |
Oop I haven't heard from them, thank you! I've been following discussions here: angular-eslint/angular-eslint#2094 and here: ReactiveX/rxjs#7492 , as well as issues on this repo itself. Is there anywhere else discussions are happening? |
It is probably in closed conversations for now. But I'm happy to contribute to your work while the ecosystem aligns. |
The Problem:
Fixes: #11
Previous Behavior
Javascript private variables like
#subscriptionwere not supported forprefer-takeuntilandprefer-compositionrulesCurrent Behavior
It allows for the
prefer-takeuntilandprefer-compositionrules to use Javascript private variables.