Skip to content

Commit 0b71e3d

Browse files
author
firgavin
committed
Add flag to skip checking resources when fully delete app
1 parent e7d9e9f commit 0b71e3d

2 files changed

Lines changed: 18 additions & 0 deletions

File tree

pkg/kapp/cmd/app/delete.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ type DeleteOptions struct {
2929
ApplyFlags ApplyFlags
3030
ResourceTypesFlags ResourceTypesFlags
3131
PrevAppFlags PrevAppFlags
32+
DeleteFlags DeleteFlags
3233
}
3334

3435
type changesSummary struct {
@@ -56,6 +57,7 @@ func NewDeleteCmd(o *DeleteOptions, flagsFactory cmdcore.FlagsFactory) *cobra.Co
5657
o.ApplyFlags.SetWithDefaults("", ApplyFlagsDeleteDefaults, cmd)
5758
o.ResourceTypesFlags.Set(cmd)
5859
o.PrevAppFlags.Set(cmd)
60+
o.DeleteFlags.Set(cmd)
5961
return cmd
6062
}
6163

@@ -151,6 +153,10 @@ func (o *DeleteOptions) Run() error {
151153

152154
touch := ctlapp.Touch{App: app, Description: "delete", IgnoreSuccessErr: true}
153155

156+
if o.DeleteFlags.DisableCheckingFullDeletion {
157+
shouldFullyDeleteApp = false
158+
}
159+
154160
err = touch.Do(func() error {
155161
err := clusterChangeSet.Apply(clusterChangesGraph)
156162
if err != nil {

pkg/kapp/cmd/app/delete_flags.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
package app
2+
3+
import "github.com/spf13/cobra"
4+
5+
type DeleteFlags struct {
6+
DisableCheckingFullDeletion bool
7+
}
8+
9+
func (s *DeleteFlags) Set(cmd *cobra.Command) {
10+
cmd.Flags().BoolVar(&s.DisableCheckingFullDeletion, "dangerous-disable-checking-app-deletion",
11+
false, "Skip checking remaining resources when fully delete app")
12+
}

0 commit comments

Comments
 (0)