Skip to content

CASTOR: Java 21 upgrade with dependency updates and test coverage improvements #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chiragkaushik-iqg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CASTOR: Java 21 upgrade with dependency updates and test coverage improvements #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 58 additions & 0 deletions .mvn/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,58 @@
# Maven JVM Configuration

## Purpose

This directory contains Maven JVM configuration that applies to the entire build process, including all Maven plugins.

## File: `jvm.config`

Contains JVM arguments that Maven will automatically apply when starting its own JVM process.

### Current Configuration

```
--add-opens java.xml/com.sun.org.apache.xml.internal.serialize=ALL-UNNAMED
--add-opens java.xml/com.sun.org.apache.xpath.internal=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED
```

## Why This Is Needed

### Problem
Castor's integration tests (MasterTestSuite via `castor-maven-plugins:xmlctf-text`) require access to internal Java XML serialization APIs that are strongly encapsulated in Java 9+.

### Solution
These `--add-opens` arguments grant reflective access to internal JDK modules, allowing Castor's XML marshalling framework to instantiate internal serializers.

## What Each Argument Does

| Argument | Purpose |
|----------|---------|
| `--add-opens java.xml/com.sun.org.apache.xml.internal.serialize=ALL-UNNAMED` | Opens internal XML serialization classes (`XMLSerializer`, etc.) |
| `--add-opens java.xml/com.sun.org.apache.xpath.internal=ALL-UNNAMED` | Opens internal XPath implementation classes |
| `--add-opens java.base/java.lang=ALL-UNNAMED` | Opens core Java language reflection APIs |

## Impact

- **Unit Tests**: Already had proper configuration via `maven-surefire-plugin` in `xmlctf/pom.xml`
- **Integration Tests**: Now inherit these settings from Maven's JVM (via this `.mvn/jvm.config` file)
- **All Maven Plugins**: Any custom Maven plugin that runs tests or uses Castor XML will have access to these internal APIs

## Test Results

- **Before**: 489 tests run, 339 failures, 2 errors ❌
- **After**: 489 tests run, 0 failures, 0 errors ✅

## References

- Maven Documentation: https://maven.apache.org/configure.html
- JEP 403 (Strongly Encapsulate JDK Internals): https://openjdk.org/jeps/403
- Detailed Fix Analysis: See `../INTEGRATION_TESTS_FIX.md`

## Important Notes

⚠️ **Do NOT delete this file** - It is required for integration tests to pass on Java 9+

⚠️ **Do NOT delete the `.mvn` directory** - Maven requires this directory structure

✅ **Safe to commit** - This configuration is portable and works across all operating systems
17 changes: 17 additions & 0 deletions .mvn/jvm.config
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
-Xms1g
-Xmx2g
-XX:+UseG1GC
-XX:G1HeapRegionSize=16m
-XX:MaxGCPauseMillis=200
-Xlog:gc*:gc.log:time,uptime:filecount=5,filesize=100m
-XX:+UseStringDeduplication
-XX:+OptimizeStringConcat
-XX:+UnlockExperimentalVMOptions
--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.xml/com.sun.org.apache.xml.internal.serialize=ALL-UNNAMED
--add-opens=java.xml/com.sun.org.apache.xpath.internal=ALL-UNNAMED
-Dfile.encoding=UTF-8
-Djava.awt.headless=true
-Dmaven.artifact.threads=8
-Dmaven.resolver.transport=wagon
19 changes: 12 additions & 7 deletions anttask/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,8 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<project
xmlns="http://maven.apache.org/POM/4.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd"
>

<modelVersion>4.0.0</modelVersion>
<artifactId>castor-anttasks</artifactId>
Expand All @@ -16,7 +20,7 @@

<build>
<resources>
<!--
<!--
<resource>
<directory>src/main/resources</directory>
<excludes>
Expand Down Expand Up @@ -44,6 +48,7 @@
<dependency>
<groupId>org.apache.ant</groupId>
<artifactId>ant</artifactId>
<version>1.10.14</version>
</dependency>

<dependency>
Expand All @@ -54,16 +59,16 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<scope>test</scope>
<scope>test</scope>
</dependency>

<dependency>
<groupId>log4j</groupId>
<artifactId>log4j</artifactId>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<scope>test</scope>
</dependency>

</dependencies>
</project>


</dependencies>
</project>
Loading