Merge pull request #930 from Wunderbyte-GmbH/MOODLE_500_STABLE

Fix #928: User profile fields are not correctly created in response xml

Author: danmarsden

idp/sso.php

@@ -89,10 +89,12 @@
 // Construct attributes in XML.
 $attributexml = '';
 foreach ((array)$attributes as $name => $value) {
-    $attributexml .= '<saml:Attribute Name="' . $name .
-        '" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified">' .
-        '<saml:AttributeValue>' . htmlspecialchars($value) . '</saml:AttributeValue>' .
-        '</saml:Attribute>' . "\n";
+    if (is_string($value)) {
+        $attributexml .= '<saml:Attribute Name="' . $name .
+                '" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:unspecified">' .
+                '<saml:AttributeValue>' . htmlspecialchars($value) . '</saml:AttributeValue>' .
+                '</saml:Attribute>' . "\n";
+    }
 }
 $email = htmlspecialchars($USER->email);
 // Construct XML without signature.