From 3aba542256f247505e8863b4f514e0cbcb999be9 Mon Sep 17 00:00:00 2001 From: Sasha Anastasi Date: Thu, 16 Nov 2023 13:58:47 +1300 Subject: [PATCH 1/3] auth.php: add supports_mfa function for T18 core_mfa compatibility test --- auth.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/auth.php b/auth.php index 1cb87358a..2b95ef069 100644 --- a/auth.php +++ b/auth.php @@ -34,4 +34,7 @@ */ class auth_plugin_saml2 extends \auth_saml2\auth { + public static function supports_mfa(): bool { + return true; + } } From 8faa8f96dda62ab8105088782aba3f6f84c68bd5 Mon Sep 17 00:00:00 2001 From: Sasha Anastasi Date: Thu, 16 Nov 2023 14:18:03 +1300 Subject: [PATCH 2/3] Add documentation for new function --- auth.php | 3 +++ 1 file changed, 3 insertions(+) diff --git a/auth.php b/auth.php index 2b95ef069..2f52fe554 100644 --- a/auth.php +++ b/auth.php @@ -34,6 +34,9 @@ */ class auth_plugin_saml2 extends \auth_saml2\auth { + /** + * @inheritDoc + */ public static function supports_mfa(): bool { return true; } From 3cded896daa584fb9a19ba894b6d75f068a52ce7 Mon Sep 17 00:00:00 2001 From: Sasha Anastasi Date: Thu, 16 Nov 2023 15:35:30 +1300 Subject: [PATCH 3/3] Align documentation with standard --- auth.php | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/auth.php b/auth.php index 2f52fe554..5830ef81b 100644 --- a/auth.php +++ b/auth.php @@ -35,7 +35,9 @@ class auth_plugin_saml2 extends \auth_saml2\auth { /** - * @inheritDoc + * Returns true if the plugin supports the new login flow for MFA. + * + * @return bool True */ public static function supports_mfa(): bool { return true;