Skip to content

Allow IdP to have separate config settings including field mappings#902

Open
danmarsden wants to merge 2 commits into
MOODLE_500_STABLEfrom
idpseparateconfig
Open

Allow IdP to have separate config settings including field mappings#902
danmarsden wants to merge 2 commits into
MOODLE_500_STABLEfrom
idpseparateconfig

Conversation

@danmarsden

Copy link
Copy Markdown
Member

rebased version of #804

@danmarsden

Copy link
Copy Markdown
Member Author

not ready for merging yet - currently reviewing and testing.

@danmarsden

Copy link
Copy Markdown
Member Author

@sarahjcotton @jacdsouza - do you guys have any modified versions of this one? - it seems to be failing unit tests for me with errors like the following: (github actions isn't triggering here, but possibly due to the 5.0 branch being tested.)

1) auth_saml2\auth_test::test_update_custom_user_profile_fields with data set #0 ([['Test data']])
Failed asserting that false is true.
moodle/auth/saml2/tests/auth_test.php:1253
2) auth_saml2\auth_test::test_update_custom_user_profile_fields with data set #1 ([['A different string']])
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1253
3) auth_saml2\auth_test::test_missing_user_custom_profile_fields with data set #0 ([['Test data']])
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1300
4) auth_saml2\auth_test::test_missing_user_custom_profile_fields with data set #1 ([['A different string']])
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1300
5) auth_saml2\auth_test::test_update_user_profile_fields_updates_username_on_creation
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1411
6) auth_saml2\auth_test::test_update_user_profile_fields_updates_username_on_creation_case_insensitive
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1437
7) auth_saml2\auth_test::test_update_user_profile_fields_updates_mapping_field_on_creation
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1489
8) auth_saml2\auth_test::test_update_user_profile_fields_multi
Failed asserting that false is true.
/moodle/auth/saml2/tests/auth_test.php:1554

@jackson-catalyst

Copy link
Copy Markdown

Hey @danmarsden we haven't yet but it's in our Dev pipeline

@Menrath

Menrath commented May 5, 2026

Copy link
Copy Markdown

I guess most of this use cases this PR covers could be dealt with SAML attribute filters?

@danmarsden

Copy link
Copy Markdown
Member Author

@Menrath yes we have a few clients with multiple idps using proc filters but they are cumbersome to set up so we're hoping to land this improvement at some point in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants