Fix autoloading issue in core moodle tests#959
Open
kristian-94 wants to merge 1 commit into
Open
Conversation
kristian-94
force-pushed
the
bugfix/core-autoloading-tests
branch
2 times, most recently
from
257b9d1 to
7a70832
Compare
SimpleSAML 2.4 bundles Nyholm/psr7; once loaded, Slim's PSR-17 discovery picks it over Guzzle and breaks core router tests in the same process. Pin the factory list to Guzzle in setuplib.php and from every test file via a shared tests/psr17_factory_pin.php include.
kristian-94
force-pushed
the
bugfix/core-autoloading-tests
branch
from
7a70832 to
69b3ac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #958
This is one way to fix it unless the core moodle test was going to change, which I think makes more sense than this change..