fix: improve wantsurl handling from loginpage list#965
Merged
Conversation
keevan
reviewed
Jun 22, 2026
keevan
left a comment
keevan
left a comment
Contributor
There was a problem hiding this comment.
Also I think we need a version bump.
keevan
approved these changes
Jun 22, 2026
keevan
left a comment
keevan
left a comment
Contributor
There was a problem hiding this comment.
Thanks for making the changes, looks good. Okay to merge after CI passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/catalyst/moodle-auth_saml2/blob/MOODLE_500_STABLE/classes/auth.php#L291
This line sets up the button with 'wants' as a parameter. But then login.php never checks it. This patch just improves the case so that both wantsurl and wants are handled as parameters.