Skip to content

fix: improve wantsurl handling from loginpage list #965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keevan merged 1 commit into from
Jun 22, 2026
Merged

fix: improve wantsurl handling from loginpage list #965

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion login.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@
// @codingStandardsIgnoreEnd
require('setup.php');

$wantsurl = optional_param('wantsurl', '', PARAM_LOCALURL); // Overrides $SESSION->wantsurl if given.
// Get the wants if set. May be set as either wantsurl or wants from the button on the login page.
$wantsurl = optional_param('wantsurl', '', PARAM_LOCALURL) ?: optional_param('wants', '', PARAM_LOCALURL);
if ($wantsurl !== '') {
// This is later used in core_login_get_return_url().
$SESSION->wantsurl = (new moodle_url($wantsurl))->out(false);
Expand Down
4 changes: 2 additions & 2 deletions version.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@

defined('MOODLE_INTERNAL') || die();

$plugin->version = 2025040403; // The current plugin version (Date: YYYYMMDDXX).
$plugin->release = 2025040403; // Match release exactly to version.
$plugin->version = 2025040404; // The current plugin version (Date: YYYYMMDDXX).
$plugin->release = 2025040404; // Match release exactly to version.
$plugin->requires = 2024100700; // Requires Moodle 4.5
$plugin->component = 'auth_saml2'; // Full name of the plugin (used for diagnostics).
$plugin->maturity = MATURITY_STABLE;
Expand Down
Loading