Fix codechecker issues in email_action_step_test

Author: djarran

tests/email_action_step_test.php

@@ -19,7 +19,7 @@
 defined('MOODLE_INTERNAL') || die();
 
 global $CFG;
-require_once(__DIR__.'/fixtures/user_event_fixture.php');
+require_once(__DIR__ . '/fixtures/user_event_fixture.php');
 
 /**
  * Test of the email action
@@ -28,6 +28,7 @@
  * @author     Aaron Wells <aaronw@catalyst.net.nz>
  * @copyright  Catalyst IT 2018
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ * @covers     \tool_trigger\steps\actions\email_action_step
  */
 final class email_action_step_test extends \advanced_testcase {
     use \tool_trigger_user_event_fixture;
@@ -60,7 +61,7 @@ public function test_execute_basic(): void {
         $step = new \tool_trigger\steps\actions\email_action_step(json_encode($settings));
 
         // Run the step.
-        list($status) = $step->execute(null, null, $this->event, []);
+        [$status] = $step->execute(null, null, $this->event, []);
         $this->assertTrue($status);
 
         // Retrieve the messages sent (should be just one).
@@ -97,7 +98,7 @@ public function test_execute_external_email_address(): void {
         $step = new \tool_trigger\steps\actions\email_action_step(json_encode($settings));
 
         // Execute the step.
-        list($status, $stepresults) = $step->execute(null, null, $this->event, []);
+        [$status, $stepresults] = $step->execute(null, null, $this->event, []);
         $this->assertTrue($status);
 
         // Retrieve the message.
@@ -129,7 +130,7 @@ public function test_execute_multiple_email_addresses(): void {
         $step = new \tool_trigger\steps\actions\email_action_step(json_encode($settings));
 
         // Execute the step.
-        list($status, $stepresults) = $step->execute(null, null, $this->event, []);
+        [$status, $stepresults] = $step->execute(null, null, $this->event, []);
         $this->assertTrue($status);
 
         // Retrieve the messages.
@@ -158,7 +159,7 @@ public function test_execute_multiple_email_addresses_with_datafields(): void {
         ];
 
         // Execute the step.
-        list($status) = $step->execute(null, null, $this->event, $prevstepresults);
+        [$status] = $step->execute(null, null, $this->event, $prevstepresults);
         $this->assertTrue($status);
 
         // Retrieve the messages.
@@ -182,7 +183,7 @@ public function test_execute_with_datafields(): void {
         ];
 
         // Run the step.
-        list($status) = $step->execute(null, null, $this->event, $prevstepresults);
+        [$status] = $step->execute(null, null, $this->event, $prevstepresults);
         $this->assertTrue($status);
 
         // Retrieve the messages sent (should be just one).