Allow matchers to be used in constexpr code

src/catch2/matchers/catch_matchers.cpp

@@ -19,7 +19,5 @@ namespace Matchers {
         return m_cachedToString;
     }
 
-    MatcherUntypedBase::~MatcherUntypedBase() = default;
-
 } // namespace Matchers
 } // namespace Catch

src/catch2/matchers/catch_matchers.hpp

@@ -31,7 +31,7 @@ namespace Matchers {
         std::string toString() const;
 
     protected:
-        virtual ~MatcherUntypedBase(); // = default;
+        virtual ~MatcherUntypedBase() = default;
         virtual std::string describe() const = 0;
         mutable std::string m_cachedToString;
     };

src/catch2/matchers/catch_matchers_templated.cpp

@@ -9,8 +9,6 @@
 
 namespace Catch {
 namespace Matchers {
-    MatcherGenericBase::~MatcherGenericBase() = default;
-
     namespace Detail {
 
         std::string describe_multi_matcher(StringRef combine, std::string const* descriptions_begin, std::string const* descriptions_end) {

src/catch2/matchers/catch_matchers_templated.hpp

@@ -24,7 +24,7 @@ namespace Matchers {
     class MatcherGenericBase : public MatcherUntypedBase {
     public:
         MatcherGenericBase() = default;
-        ~MatcherGenericBase() override; // = default;
+        ~MatcherGenericBase() override = default;
 
         MatcherGenericBase(MatcherGenericBase const&) = default;
         MatcherGenericBase(MatcherGenericBase&&) = default;