Skip to content

Brackets (e.g. ]) are being masked in telemetry output, breaking chart rendering #92

@ncusimano-livefront

Description

@ncusimano-livefront

Summary

I have noticed that closing brackets (]) are being masked/replaced with *** in our job summaries.

This keeps all the charts from rendering causing us to need to manually grab the URL to view the output chart for a specific metric such as memory usage.

Environment

GitHub Actions runner: ubuntu-latest
Action version: catchpoint/workflow-telemetry-action@v2

Notes

I understand GitHub masks values that match secrets automatically, but in this case the ] character does not seem like it should be interpreted as a secret of course.

e.g.

## Workflow Telemetry - Merge PR to Main / Deploy
Workflow telemetry for commit [772bb064a1524ff7bed55d95c82671cb58a3d06e***(...)
You can access workflow job details [here***(...)

Notably, output in PR comments are NOT exhibiting this behavior, just output in the job summary.

Questions

Could this be related to how the action processes or encodes output before posting?

Could this be affected by secrets possibly being exposed to argv from OTHER actions after this action is started?

Can you clarify why ] characters are being masked, and if this can be fixed or worked around so that charts render correctly in job summaries?

Example

Expected output:

test

Actual output:

![test***(https://httpbin.org/image/png)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions