Add quality standards and team command design patterns documentation

- Introduced a new quality standards document outlining assessment criteria for team command .md files, including completeness, pattern compliance, integration, and consistency dimensions.
- Established quality gates and issue classification for errors, warnings, and informational notes.
- Created a comprehensive team command design patterns document detailing infrastructure and collaboration patterns, including message bus integration, YAML front matter requirements, task lifecycle, five-phase execution structure, and error handling.
- Included a pattern selection guide for collaboration scenarios to enhance team interaction models.

Author: catlog22

.ccw/workflows/cli-templates/schemas/solution-schema.json

@@ -24,7 +24,7 @@
       "description": "Task breakdown for this solution",
       "items": {
         "type": "object",
-        "required": ["id", "title", "scope", "action", "implementation", "acceptance"],
+        "required": ["id", "title", "scope", "action", "implementation"],
         "properties": {
           "id": {
             "type": "string",
@@ -46,8 +46,26 @@
             "type": "string",
             "description": "1-2 sentences describing what to implement"
           },
+          "files": {
+            "type": "array",
+            "description": "Files affected by this task (preferred over modification_points)",
+            "items": {
+              "type": "object",
+              "required": ["path"],
+              "properties": {
+                "path": { "type": "string", "description": "File path relative to project root" },
+                "action": { "type": "string", "enum": ["modify", "create", "delete"], "description": "Type of file operation" },
+                "target": { "type": "string", "description": "Target symbol or location within file" },
+                "change": { "type": "string", "description": "Description of the change" },
+                "changes": { "type": "array", "items": { "type": "string" }, "description": "Multiple changes to the file" },
+                "conflict_risk": { "type": "string", "enum": ["low", "medium", "high"], "description": "Risk of merge conflict" }
+              }
+            }
+          },
           "modification_points": {
             "type": "array",
+            "deprecated": true,
+            "description": "DEPRECATED: Use 'files' instead. Legacy field for backward compatibility.",
             "items": {
               "type": "object",
               "properties": {
@@ -69,18 +87,35 @@
               "unit": { "type": "array", "items": { "type": "string" } },
               "integration": { "type": "array", "items": { "type": "string" } },
               "commands": { "type": "array", "items": { "type": "string" } },
-              "coverage_target": { "type": "number" }
+              "coverage_target": { "type": "number" },
+              "manual_checks": { "type": "array", "items": { "type": "string" }, "description": "Manual verification steps" },
+              "success_metrics": { "type": "array", "items": { "type": "string" }, "description": "Success metrics for the task" }
             }
           },
           "regression": {
             "type": "array",
             "items": { "type": "string" },
             "description": "Regression check points"
           },
+          "convergence": {
+            "type": "object",
+            "description": "Convergence criteria & verification (preferred over acceptance)",
+            "required": ["criteria"],
+            "properties": {
+              "criteria": { "type": "array", "items": { "type": "string" } },
+              "verification": {
+                "oneOf": [
+                  { "type": "string" },
+                  { "type": "array", "items": { "type": "string" } }
+                ]
+              },
+              "definition_of_done": { "type": "string" }
+            }
+          },
           "acceptance": {
             "type": "object",
-            "description": "Acceptance criteria & verification",
-            "required": ["criteria", "verification"],
+            "deprecated": true,
+            "description": "DEPRECATED: Use 'convergence' instead. Legacy field for backward compatibility.",
             "properties": {
               "criteria": { "type": "array", "items": { "type": "string" } },
               "verification": { "type": "array", "items": { "type": "string" } },
@@ -105,17 +140,41 @@
           },
           "estimated_minutes": {
             "type": "integer",
-            "description": "Estimated time to complete"
+            "description": "DEPRECATED: Use 'effort' instead. Estimated time to complete."
+          },
+          "effort": {
+            "type": "string",
+            "enum": ["small", "medium", "large", "xlarge"],
+            "description": "Effort estimate for the task"
           },
           "status": {
             "type": "string",
             "description": "Task status (optional, for tracking)"
           },
           "priority": {
-            "type": "integer",
-            "minimum": 1,
-            "maximum": 5,
-            "default": 3
+            "oneOf": [
+              { "type": "string", "enum": ["critical", "high", "medium", "low"] },
+              { "type": "integer", "minimum": 1, "maximum": 5 }
+            ],
+            "default": "medium",
+            "description": "Task priority. Prefer string enum; integer 1-5 accepted for backward compatibility."
+          }
+        },
+        "anyOf": [
+          { "required": ["convergence"] },
+          { "required": ["acceptance"] }
+        ],
+        "_migration": {
+          "description": "Field migration mapping from legacy to current format",
+          "mappings": {
+            "modification_points[].file": "files[].path",
+            "modification_points[].target": "files[].target",
+            "modification_points[].change": "files[].change",
+            "acceptance.criteria": "convergence.criteria",
+            "acceptance.verification": "convergence.verification",
+            "acceptance.manual_checks": "test.manual_checks",
+            "priority (integer 1-5)": "priority (string enum)",
+            "estimated_minutes": "effort"
           }
         }
       }

.claude/agents/issue-plan-agent.md

@@ -226,13 +226,13 @@ function decomposeTasks(issue, exploration) {
     scope: inferScope(group),              // Module path
     action: inferAction(group),            // Create | Update | Implement | ...
     description: group.description,
-    modification_points: mapModificationPoints(group),
+    files: mapFiles(group),                // [{path, target, change, action?, conflict_risk?}]
     implementation: generateSteps(group),  // Step-by-step guide
     test: {
       unit: generateUnitTests(group),
       commands: ['npm test']
     },
-    acceptance: {
+    convergence: {
       criteria: generateCriteria(group),   // Quantified checklist
       verification: generateVerification(group)
     },
@@ -242,7 +242,7 @@ function decomposeTasks(issue, exploration) {
       message_template: generateCommitMsg(group)
     },
     depends_on: inferDependencies(group, tasks),
-    priority: calculatePriority(group)     // 1-5 (1=highest)
+    priority: calculatePriorityEnum(group) // "critical"|"high"|"medium"|"low"
   }));
 
   // GitHub Reply Task: Add final task if issue has github_url
@@ -254,20 +254,20 @@ function decomposeTasks(issue, exploration) {
       scope: 'github',
       action: 'Notify',
       description: `Comment on GitHub issue to report completion status`,
-      modification_points: [],
+      files: [],
       implementation: [
         `Generate completion summary (tasks completed, files changed)`,
         `Post comment via: gh issue comment ${issue.github_number || extractNumber(issue.github_url)} --body "..."`,
         `Include: solution approach, key changes, verification results`
       ],
       test: { unit: [], commands: [] },
-      acceptance: {
+      convergence: {
         criteria: ['GitHub comment posted successfully', 'Comment includes completion summary'],
         verification: ['Check GitHub issue for new comment']
       },
       commit: null,  // No commit for notification task
       depends_on: lastTaskId ? [lastTaskId] : [],  // Depends on last implementation task
-      priority: 5    // Lowest priority (run last)
+      priority: "low"    // Lowest priority (run last)
     });
   }
 
@@ -370,10 +370,10 @@ Each line is a solution JSON containing tasks. Schema: `cat ~/.ccw/workflows/cli
 ### 3.2 Validation Checklist
 
 - [ ] ACE search performed for each issue
-- [ ] All modification_points verified against codebase
+- [ ] All files[] paths verified against codebase
 - [ ] Tasks have 2+ implementation steps
 - [ ] All 5 lifecycle phases present
-- [ ] Quantified acceptance criteria with verification
+- [ ] Quantified convergence criteria with verification
 - [ ] Dependencies form valid DAG
 - [ ] Commit follows conventional commits
 
@@ -389,7 +389,7 @@ Each line is a solution JSON containing tasks. Schema: `cat ~/.ccw/workflows/cli
 4. Fetch issue details via `ccw issue status <id> --json`
 5. **Analyze failure history**: Check `issue.feedback` for type='failure', stage='execute'
 6. **For replanning**: Reference previous failures in `solution.approach`, add prevention steps
-7. Quantify acceptance.criteria with testable conditions
+7. Quantify convergence.criteria with testable conditions
 8. Validate DAG before output
 9. Evaluate each solution with `analysis` and `score`
 10. Write solutions to `.workflow/issues/solutions/{issue-id}.jsonl` (append mode)