Skip to content

Commit fd3a005

Browse files
author
catlog22
committed
fix(codex-skills): migrate 9 skills from v3 close_agent({id:}) to v4 close_agent({target:})
Also fix wait_agent({ids:}) → wait_agent({targets:}) in workflow-test-fix-cycle. Affects: brainstorm, clean, issue-discover, review-cycle, roadmap-with-file, spec-setup, workflow-plan, workflow-tdd-plan, workflow-test-fix-cycle (36 occurrences).
1 parent 81702c9 commit fd3a005

15 files changed

Lines changed: 37 additions & 37 deletions

File tree

.codex/skills/brainstorm/SKILL.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,7 @@ Follow the same analysis protocol as wave role analysis but with interactive ref
557557
})
558558
559559
wait_agent({ targets: [agentId] })
560-
close_agent({ id: agentId })
560+
close_agent({ target: agentId })
561561
562562
console.log(`\n✓ ${roleName} analysis complete: ${roleDir}/analysis.md`)
563563
}
@@ -632,7 +632,7 @@ Evaluate complexity score (0-8):
632632
})
633633
634634
wait_agent({ targets: [synthesisAgent] })
635-
close_agent({ id: synthesisAgent })
635+
close_agent({ target: synthesisAgent })
636636
```
637637

638638
3. **Completion Summary**

.codex/skills/clean/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ Format:
217217
}
218218

219219
} finally {
220-
if (exploreAgent) close_agent({ id: exploreAgent })
220+
if (exploreAgent) close_agent({ target: exploreAgent })
221221
}
222222
```
223223

.codex/skills/issue-discover/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ Continue with plan generation.
296296
Clean up subagent resources (irreversible).
297297

298298
```javascript
299-
close_agent({ id: agentId })
299+
close_agent({ target: agentId })
300300
```
301301

302302
## Core Guidelines

.codex/skills/issue-discover/phases/02-discover.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ Research industry best practices for ${perspective} using Exa search
225225
timeout_ms: 300000 // 5 minutes
226226
});
227227

228-
close_agent({ id: exaAgentId });
228+
close_agent({ target: exaAgentId });
229229
}
230230
```
231231

.codex/skills/review-cycle/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -358,7 +358,7 @@ Continue with analysis generation.
358358
Clean up subagent resources (irreversible).
359359

360360
```javascript
361-
close_agent({ id: agentId })
361+
close_agent({ target: agentId })
362362
```
363363

364364
## Progress Tracking Pattern

.codex/skills/review-cycle/phases/02-parallel-review.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ const deepDiveResult = wait_agent({
413413
});
414414

415415
// Cleanup
416-
close_agent({ id: deepDiveAgentId });
416+
close_agent({ target: deepDiveAgentId });
417417
```
418418

419419
## Dimension Guidance Reference

.codex/skills/review-cycle/phases/07-fix-parallel-planning.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ for (let i = 0; i < batches.length; i += MAX_PARALLEL) {
6060
}
6161

6262
// Step 4: Cleanup agents in this chunk
63-
agentIds.forEach(({ agentId }) => close_agent({ id: agentId }));
63+
agentIds.forEach(({ agentId }) => close_agent({ target: agentId }));
6464
}
6565

6666
// Aggregate partial plans → fix-plan.json
@@ -210,7 +210,7 @@ const result = wait_agent({
210210
});
211211

212212
// Cleanup
213-
close_agent({ id: agentId });
213+
close_agent({ target: agentId });
214214
```
215215

216216
## Output

.codex/skills/review-cycle/phases/08-fix-execution.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ const execResult = wait_agent({
227227
});
228228

229229
// Cleanup
230-
close_agent({ id: execAgentId });
230+
close_agent({ target: execAgentId });
231231
```
232232

233233
## Output

.codex/skills/roadmap-with-file/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ Continue with plan generation.
9090
Clean up subagent resources (irreversible).
9191

9292
```javascript
93-
close_agent({ id: agentId })
93+
close_agent({ target: agentId })
9494
```
9595

9696
---
@@ -574,7 +574,7 @@ Return findings as JSON with schema:
574574
timeout_ms: 120000
575575
})
576576

577-
close_agent({ id: exploreAgentId })
577+
close_agent({ target: exploreAgentId })
578578

579579
if (exploreResult.status[exploreAgentId].completed) {
580580
codebaseContext = exploreResult.status[exploreAgentId].completed
@@ -666,7 +666,7 @@ ${selectedMode === 'progressive' ? `**Progressive Mode**:
666666
timeout_ms: 300000 // 5 minutes for complex decomposition
667667
})
668668

669-
close_agent({ id: decompositionAgentId })
669+
close_agent({ target: decompositionAgentId })
670670

671671
if (!decompositionResult.status[decompositionAgentId].completed) {
672672
throw new Error('Decomposition agent failed to complete')

.codex/skills/spec-setup/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -193,7 +193,7 @@ Project root: ${projectRoot}
193193
}
194194

195195
} finally {
196-
if (exploreAgent) close_agent({ id: exploreAgent })
196+
if (exploreAgent) close_agent({ target: exploreAgent })
197197
}
198198
```
199199

0 commit comments

Comments
 (0)