fix!: remove O.show_end_of_buffer#982
Merged
Merged
Conversation
removing this option since its behavior is dependent on a
non-transparent background.
if users want to keep this, they should use:
```lua
vim.opt.fillchars:append({ eob = " " })
```
#980
sgoudham
approved these changes
Mar 21, 2026
Contributor
sgoudham
left a comment
sgoudham
left a comment
There was a problem hiding this comment.
I'd classify this as a breaking change since you're removing a user facing option, and it'll no longer work as expected?
Otherwise, seems good to remove since it's a bit odd to control that in the theme.
sgoudham
changed the title
O.show_end_of_bufferO.show_end_of_buffer
vollowx
approved these changes
Mar 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removing this option since its behavior is dependent on a non-transparent background.
if users want to keep this, they should use:
fix #980