error in documentation and variable description

[falcocoris]

There seems to be some outdated documentation, along with errors in it.

The following part got me wrong :

variable "runner_gitlab" {
  description = <<-EOT
    ca_certificate = Trusted CA certificate bundle (PEM format).
    certificate = Certificate of the GitLab instance to connect to (PEM format).
    registration_token = (deprecated, This is replaced by the `registration_token` in `runner_gitlab_registration_config`.) Registration token to use to register the Runner.
    runner_version = Version of the [GitLab Runner](https://gitlab.com/gitlab-org/gitlab-runner/-/releases). Make sure that it is available for your AMI. See https://packages.gitlab.com/app/runner/gitlab-runner/search?dist=amazon%2F2023&filter=rpms&page=1&q=
    url = URL of the GitLab instance to connect to.
    url_clone = URL of the GitLab instance to clone from. Use only if the agent can’t connect to the GitLab URL.
    access_token_secure_parameter_store_name = (deprecated) The name of the SSM parameter to read the GitLab access token from. It must have the `api` scope and be pre created.
    preregistered_runner_token_ssm_parameter_name = The name of the SSM parameter to read the preregistered GitLab Runner token from.
  EOT
  type = object({
    ca_certificate                                = optional(string, "")
    certificate                                   = optional(string, "")
    registration_token                            = optional(string, "__REPLACED_BY_USER_DATA__") # deprecated, removed in 8.0.0
    runner_version                                = optional(string, "16.0.3")
    url                                           = optional(string, "")
    url_clone                                     = optional(string, "")
    access_token_secure_parameter_store_name      = optional(string, "gitlab-runner-access-token") # deprecated, removed in 8.0.0
    preregistered_runner_token_ssm_parameter_name = optional(string, "")
  })
}

This part :
registration_token = optional(string, "__REPLACED_BY_USER_DATA__") # deprecated, removed in 8.0.0

version is 9.2.2 and this is still needed.
The documentation says it's replaced with preregistered_runner_token_ssm_parameter_name but it isn't.

And what is it with all these removed in 8.0.0 but still in the documentation anyways ?

I can do a PR to fix the documentation but it's not clear for me what needs to be done, if you explain a bit, i can get to it.

[kayman-mk]

Unclear to me either. I think it was planned to remove the registration stuff as GitLab provides now different methods to register a agent.

[kayman-mk]

Just checked the code. The whole stuff can be removed. The correct way is to register the runner manually in GitLab and put the token in a SSM parameter. This parameter is placed in runner_gitlab.preregistered_runner_token_ssm_parameter_name.

Would be cool if you (@falcocoris) still find the time to improve the docs, examples and clear the code. We can create a major release for that. Still interested?