[WIP] fix fleeting plugin installation for docker autoscaler#1260
[WIP] fix fleeting plugin installation for docker autoscaler#1260daveaie wants to merge 7 commits into
Conversation
|
Hey @daveaie! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
kayman-mk
left a comment
kayman-mk
left a comment
There was a problem hiding this comment.
Great work!
I think we have to check the installation of the plugin. So I prefer to have this in a separate PR and merge the other changes before,
| update_interval = "${runners_update_interval}" | ||
| update_interval_when_expecting = "${runners_update_interval_when_expecting}" | ||
|
|
||
| delete_instances_on_shutdown = ${delete_instances_on_shutdown} |
There was a problem hiding this comment.
thought: does this make our Lambda function superfluous? We have it to kill the instances on shutdown of the agent.
There was a problem hiding this comment.
No, what if the runner worker crashes? What if the instance is terminated without being shut down?
## Description The fleeting plugin installation method depends on the version of the Runner used and can be automated starting with version 16.11 of the Runner. See https://docs.gitlab.com/runner/fleet_scaling/fleeting/#install-a-fleeting-plugin Related to #1260
kayman-mk
added
work-in-progress
|
Looks like this PR should not have been closed. |
3 participants
Description
Hello everyone,
i have pushed 3 improvement to use docker autoscaler gitlub runner:
Migrations required
No migration required.
Verification
I'm using my version of this module in our gitlab on premise installation since a week.
The reason I implemented this fix is that with the old installation method of the fleeting plugin, the runners did not scale down correctly as indicated in this issue