chore: update kms settings for launch template to allow default kms#1343
Merged
Conversation
Contributor
|
Hey @maxvandermeij! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
kayman-mk
approved these changes
Oct 16, 2025
kayman-mk
left a comment
kayman-mk
left a comment
Collaborator
There was a problem hiding this comment.
Sounds good to me. Thanks for fixing that.
kayman-mk
added a commit
that referenced
this pull request
Oct 27, 2025
…1349) ## Description Fix for change in `kms_key_id` validation on the launch template ebs volumes. This was implemented on the aws provider 6.16.0 https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#6160-october-9-2025. When using the default ebs kms key, it will now no longer complain about the empty "" provided to the `kms_key_id` for ebs volumes with encryption enabled. > Error: "block_device_mappings.0.ebs.0.kms_key_id" cannot be shorter than 1 character > > with module.runner.aws_launch_template.this[0], > on .terraform/modules/runner/docker_machine_fleet.tf line 42, in resource "aws_launch_template" "this": > 41: kms_key_id = local.kms_key_arn > Closes #1348 Basically duplicate of #1343 but for docker_machine_fleet instead of docker_autoscaler. Co-authored-by: Matthias Kay <matthias.kay@hlag.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for change in kms_key_id validation on the launch template ebs volumes. This was implemented on the aws provider 6.16.0 https://github.com/hashicorp/terraform-provider-aws/blob/main/CHANGELOG.md#6160-october-9-2025. When using the default ebs kms key, it will now no longer complain about the empty "" provided to the kms_key_id for ebs volumes with encryption enabled.
Closes #1342