fix: retry to assign the elastic ip

[lukashankeln]

Description

Assigning the elastic ip for the managing instance will now be retried 7 times.

This avoids issues if aws is not fast enough to release the elastic ip when updating the managing runner.

Migrations required

No

Verification

Elastic IP assignment should still work even if aws does not release the elastic ip immediately.

[github-actions]

Hey @lukashankeln! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

• the problem being solved
• the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

• /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

[tibuntu]

@kayman-mk any chance this gets a review soon? In the past rotation of the ec2 instances after certain changes went really well for us, until we started to face the issue described above. Currently we need to manually delete the instances to ensure smooth rollout.

[kayman-mk]

I have never seen problems here as I am not using EIP. Thanks for fixing this.

I added some improvements and fixed some older problems in the code. Let me know if you can go with my proposal.

[tibuntu]

@kayman-mk can this be merged soon? Causes real pain within our infrastructure.