Skip to content

fix: add pid_mode as an optional field to runner_worker_docker_options#1380

Open
cmpoon wants to merge 2 commits into
cattle-ops:mainfrom
cmpoon:patch-1
Open

fix: add pid_mode as an optional field to runner_worker_docker_options#1380
cmpoon wants to merge 2 commits into
cattle-ops:mainfrom
cmpoon:patch-1

Conversation

@cmpoon

@cmpoon cmpoon commented Jun 25, 2026

Copy link
Copy Markdown

Description

After https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6694 was shipped in gitlab-runner 19.1.0, this adds support for defining pid_mode in the module var.

Migrations required

No, this change is backward compatible.

Verification

Added pid_mode = "host" then running a gitlab job with docker ps -q | xargs docker inspect --format '{{.State.Pid}}' in script yields the expected output indicating host pid mode.

After https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6694 was shipped in gitlab-runner 19.1.0, this adds support for defining pid_mode in the module var.
@cmpoon
cmpoon requested review from kayman-mk and npalm as code owners June 25, 2026 11:20
Copilot AI review requested due to automatic review settings June 25, 2026 11:20
@github-actions

Copy link
Copy Markdown
Contributor

Hey @cmpoon! 👋

Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out

Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command.

This message was generated automatically. You are welcome to improve it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support in this Terraform module for configuring Docker executor pid_mode via the existing runner_worker_docker_options variable, aligning the module with GitLab Runner >= 19.1.0’s added pid_mode support.

Changes:

  • Extend runner_worker_docker_options object type to include optional pid_mode.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread variables.tf
@cmpoon cmpoon changed the title Add pid_mode as an optional field to runner_worker_docker_options fix: Add pid_mode as an optional field to runner_worker_docker_options Jun 25, 2026
Updated the runner_worker_docker_options section via terraform-docs to include the new pid_mode field.
@cmpoon cmpoon changed the title fix: Add pid_mode as an optional field to runner_worker_docker_options fix: add pid_mode as an optional field to runner_worker_docker_options Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants