fix: add pid_mode as an optional field to runner_worker_docker_options#1380
fix: add pid_mode as an optional field to runner_worker_docker_options#1380cmpoon wants to merge 2 commits into
Conversation
After https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6694 was shipped in gitlab-runner 19.1.0, this adds support for defining pid_mode in the module var.
|
Hey @cmpoon! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
There was a problem hiding this comment.
Pull request overview
Adds support in this Terraform module for configuring Docker executor pid_mode via the existing runner_worker_docker_options variable, aligning the module with GitLab Runner >= 19.1.0’s added pid_mode support.
Changes:
- Extend
runner_worker_docker_optionsobject type to include optionalpid_mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Updated the runner_worker_docker_options section via terraform-docs to include the new pid_mode field.
Description
After https://gitlab.com/gitlab-org/gitlab-runner/-/merge_requests/6694 was shipped in gitlab-runner 19.1.0, this adds support for defining pid_mode in the module var.
Migrations required
No, this change is backward compatible.
Verification
Added
pid_mode = "host"then running a gitlab job withdocker ps -q | xargs docker inspect --format '{{.State.Pid}}'inscriptyields the expected output indicating host pid mode.