feat: support additional_tags on worker launch template#1383
Open
lorenzstorm1 wants to merge 1 commit into
Open
feat: support additional_tags on worker launch template#1383lorenzstorm1 wants to merge 1 commit into
lorenzstorm1 wants to merge 1 commit into
Conversation
Add `additional_tags` field to `runner_worker_docker_autoscaler_instance` to allow tagging worker instances independently of the runner manager. Tags are merged into the launch template's tag_specifications for instance, volume, and network-interface resource types. Closes cattle-ops#1369 🤖 Generated with Claude Code
Contributor
|
Hey @lorenzstorm1! 👋 Thank you for your contribution to the project. Please refer to the contribution rules for a quick overview of the process. Make sure that this PR clearly explains:
With submitting this PR you confirm that you hold the rights of the code added and agree that it will published under this LICENSE. The following ChatOps commands are supported:
Simply add a comment with the command in the first line. If you need to pass more information, separate it with a blank line from the command. This message was generated automatically. You are welcome to improve it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an
additional_tagsfield torunner_worker_docker_autoscaler_instancethat applies tags exclusively to the worker launch template'stag_specifications(instance, volume, network-interface) without affecting the runner manager instance.This enables use cases like excluding ephemeral CI workers from AWS GuardDuty Runtime Monitoring while keeping the manager monitored.
Usage
Closes #1369
Changes
variables.tf: Addadditional_tags = optional(map(string), {})to therunner_worker_docker_autoscaler_instanceobjecttags.tf: Addworker_tagslocal that mergeslocal.tagswith the newadditional_tagsdocker_autoscaler.tf: Uselocal.worker_tagsintag_specificationsblocks🤖 Generated with Claude Code