Skip to content

feat: support additional_tags on worker launch template #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lorenzstorm1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

feat: support additional_tags on worker launch template #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docker_autoscaler.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,15 +44,15 @@ resource "aws_launch_template" "this" {

tag_specifications {
resource_type = "instance"
tags = local.tags
tags = local.worker_tags
}
tag_specifications {
resource_type = "volume"
tags = local.tags
tags = local.worker_tags
}
tag_specifications {
resource_type = "network-interface"
tags = local.tags
tags = local.worker_tags
}

tags = local.tags
Expand Down
2 changes: 2 additions & 0 deletions tags.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,6 @@ locals {
runner_tags_string = join(",", flatten([
for key in keys(local.runner_tags) : [key, local.runner_tags[key]]
]))

worker_tags = merge(local.tags, var.runner_worker_docker_autoscaler_instance.additional_tags)
}
2 changes: 2 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,6 +780,7 @@ variable "runner_worker_docker_autoscaler_instance" {
volume_type = The type of volume to use for the Runner Worker. `gp2`, `gp3`, `io1` or `io2` are supported.
volume_iops = Guaranteed IOPS for the volume. Only supported when using `gp3`, `io1` or `io2` as `volume_type`.
volume_throughput = Throughput in MB/s for the volume. Only supported when using `gp3` as `volume_type`.
additional_tags = Additional tags to apply exclusively to the worker launch template's tag_specifications (instance, volume, network-interface). These do not affect the runner manager.
EOT

type = object({
Expand All @@ -796,6 +797,7 @@ EOT
volume_type = optional(string, "gp2")
volume_throughput = optional(number, 125)
volume_iops = optional(number, 3000)
additional_tags = optional(map(string), {})
})
default = {}

Expand Down