Handle zero-probability decision contexts#83
Open
yfflood wants to merge 2 commits into
Open
Conversation
RyanCarey
approved these changes
Jun 27, 2026
RyanCarey
left a comment
Collaborator
There was a problem hiding this comment.
Looks and sounds like making pycid more gracefully handle an edge case.
Author
|
Added a little specification to make sure the fix only targets the case of 0-probability context. Other unexpected causes of nan will still raise RuntimeErrors. |
Author
|
@RyanCarey thanks for the review! It looks like there's a workflow awaiting maintainer approval before this can be merged :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #80
The change keeps conditional expectations on impossible events undefined by default, but lets the solver explicitly provide a neutral fallback for unreachable decision contexts.
Changes
zero_prob_valuefallback parameter toexpected_value().RuntimeErrorfor ordinary zero-probability conditional expectations.zero_prob_value=0.0only while constructing optimal decision rules, where unreachable contexts do not affect expected utility.