Skip to content

Commit 2f34e44

Browse files
authored
fetch value instead of get
1 parent 79f2ae0 commit 2f34e44

1 file changed

Lines changed: 9 additions & 11 deletions

File tree

  • causal_automl/TutorTask401_EIA_metadata_downloader_pipeline

causal_automl/TutorTask401_EIA_metadata_downloader_pipeline/eia_utils.py

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -246,25 +246,23 @@ def _extract_metadata(
246246
# Determine parameter CSV path for associated facet values.
247247
param_file_path = f"eia_parameters_v{self._version_num}/{dataset_id_clean}_parameters.csv"
248248
# Flattened metadata row for one frequency and metric combination.
249-
# TODO(gp): `.get()` will use `None` if there is a missing
250-
# value in the dictionary. Is this the intended behavior?
251249
metadata = {
252250
"url": url,
253251
"id": f"{route_clean}.{frequency_id}.{metric_id_clean}",
254252
"dataset_id": dataset_id_clean,
255-
"name": data.get("name"),
256-
"description": data.get("description"),
257-
"frequency_id": frequency.get("id"),
253+
"name": data["name"],
254+
"description": data["description"],
255+
"frequency_id": frequency["id"],
258256
"frequency_alias": frequency.get("alias"),
259-
"frequency_description": frequency.get("description"),
260-
"frequency_query": frequency.get("query"),
261-
"frequency_format": frequency.get("format"),
262-
"facets": data.get("facets"),
257+
"frequency_description": frequency["description"],
258+
"frequency_query": frequency["query"],
259+
"frequency_format": frequency["format"],
260+
"facets": data["facets"],
263261
"data": metric_id,
264262
"data_alias": metric_info.get("alias"),
265263
"data_units": metric_info.get("units"),
266-
"start_period": data.get("startPeriod"),
267-
"end_period": data.get("endPeriod"),
264+
"start_period": data["startPeriod"],
265+
"end_period": data["endPeriod"],
268266
"parameter_values_file": param_file_path,
269267
}
270268
flattened_metadata.append(metadata)

0 commit comments

Comments
 (0)