Skip to content

feat(calendar): expose ordered VALARM reminders#969

Open
silviuchingaru wants to merge 1 commit into
cbcoutinho:masterfrom
silviuchingaru:feat/ordered-valarm-reminders
Open

feat(calendar): expose ordered VALARM reminders#969
silviuchingaru wants to merge 1 commit into
cbcoutinho:masterfrom
silviuchingaru:feat/ordered-valarm-reminders

Conversation

@silviuchingaru

Copy link
Copy Markdown
Contributor

Summary

  • Adds ordered VALARM reminder parsing/serialization for calendar events and todos.
  • Supports relative reminders, absolute trigger_at reminders, ordered list updates, and explicit clearing with reminders: [].
  • Preserves existing VALARMs when unrelated event/todo fields are updated.

Test Plan

  • uv run ruff check nextcloud_mcp_server tests/unit/client/test_calendar.py
  • uv run pytest tests/unit/client/test_calendar.py -q
  • Live Nextcloud smoke test against a temporary calendar: event/todo VALARM create, preserve, update, clear; cleanup returned 204s.

@CLAassistant

CLAassistant commented Jun 25, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Adds ordered VALARM reminder parsing/serialization for events and todos.
@silviuchingaru silviuchingaru force-pushed the feat/ordered-valarm-reminders branch from 425bbf7 to a3e3446 Compare June 25, 2026 22:24
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

pi0n00r added a commit to pi0n00r/nextcloud-mcp-server that referenced this pull request Jul 6, 2026
Thanks to Silviu Chingaru for the upstream contribution. This imports the ordered VALARM reminder support into the pi0n00r fork after focused fork validation.
pi0n00r added a commit to pi0n00r/nextcloud-mcp-server that referenced this pull request Jul 6, 2026
This reverts commit 43de4d3, reversing
changes made to 98102f3.
pi0n00r added a commit to pi0n00r/nextcloud-mcp-server that referenced this pull request Jul 6, 2026
Import upstream ordered VALARM reminder support from cbcoutinho#969 and keep omitted reminders preserving existing alarms while reminders: [] clears them.

Fork hardening: round-trip standard EMAIL/reminder fields including SUMMARY, DURATION, REPEAT, and ATTENDEE when callers explicitly send reminder lists back.

Upstream commit: a3e3446 / local prior import: 8743364.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants