Create dim_instructors model#35
Open
sanaf26 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Creates the dim_instructors mart model as the final instructor dimension, selecting cleaned instructor attributes from stg_instructors and adding schema tests to validate key fields.
Changes:
- Added
dim_instructorsmodel selecting instructor identifiers and descriptive attributes fromstg_instructors - Derived
instructor_namefrom first/last name fields - Added
dim_instructors.ymlwith column-level tests (not_null/unique)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| models/marts/dim_instructors.sql | Builds the instructor dimension from stg_instructors and derives instructor_name. |
| models/marts/dim_instructors.yml | Adds schema documentation and column tests for dim_instructors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| instructor_first_name, | ||
| instructor_last_name, | ||
|
|
||
| concat(instructor_first_name, ' ', instructor_last_name) as instructor_name, |
Comment on lines
+21
to
+27
| tests: | ||
| - not_null | ||
|
|
||
| - name: instructor_name | ||
| description: "Full instructor name." | ||
| tests: | ||
| - not_null |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket - #28
Created dim_instructors as the final instructor dimension.
What I changed
Included:
Tests
Added dim_instructors.yml with column tests for key descriptive fields