Skip to content

fix(gws): resolve skillsaw linting warnings#63

Closed
not-stbenjam wants to merge 1 commit into
cblecker:mainfrom
not-stbenjam:fix/gws-skillsaw-lint
Closed

fix(gws): resolve skillsaw linting warnings#63
not-stbenjam wants to merge 1 commit into
cblecker:mainfrom
not-stbenjam:fix/gws-skillsaw-lint

Conversation

@not-stbenjam

@not-stbenjam not-stbenjam commented Jul 2, 2026

Copy link
Copy Markdown

Summary

  • Fix weak language warnings ("Note that", "gracefully") in gws-calendar, gws-drive, and gws-gmail-watch skills
  • Fix broken internal links in gws-drive by adding full https://developers.google.com prefix
  • Scope the gws/skills/** exclude in .skillsaw.yaml to only the context-budget rule instead of globally excluding all rules
  • Bump gws plugin version to 2.0.1

Test plan

  • uvx skillsaw --strict passes with 0 warnings and 0 errors

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated project configuration to use the new context-budget exclusion structure for selected files.
    • Bumped a plugin version from 2.0.0 to 2.0.1.

Fix weak language ("Note that", "gracefully"), broken internal links
(missing https://developers.google.com prefix), and scope the
gws/skills/** exclude to only the context-budget rule.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 63b5d34a-2869-407c-92e6-03d98c263546

📥 Commits

Reviewing files that changed from the base of the PR and between 0c4d493 and a480f62.

⛔ Files ignored due to path filters (3)
  • gws/skills/gws-calendar/SKILL.md is excluded by !gws/skills/**
  • gws/skills/gws-drive/SKILL.md is excluded by !gws/skills/**
  • gws/skills/gws-gmail-watch/SKILL.md is excluded by !gws/skills/**
📒 Files selected for processing (2)
  • .skillsaw.yaml
  • gws/.claude-plugin/plugin.json

📝 Walkthrough

Walkthrough

This PR restructures the .skillsaw.yaml exclude configuration by nesting it under rules.context-budget.exclude instead of a top-level exclude key, and increments the gws plugin version from 2.0.0 to 2.0.1 in plugin.json.

Changes

Config and Version Updates

Layer / File(s) Summary
Skillsaw exclude restructure
.skillsaw.yaml
Moves the gws/skills/** exclude pattern from a top-level exclude list to a nested rules.context-budget.exclude list.
Plugin version bump
gws/.claude-plugin/plugin.json
Increments the version field from 2.0.0 to 2.0.1.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Poem

A rabbit hops through yaml lines,
Nesting rules where exclude aligns.
A version tick, from zero to one,
Small changes made, the task is done. 🐇

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: fixing gws Skillsaw linting warnings.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cblecker

cblecker commented Jul 3, 2026

Copy link
Copy Markdown
Owner

@stbenjam these skills are generated from the gws CLI, so it's intentional that they are all excluded. is there something you were trying to fix here?

@stbenjam

stbenjam commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

There's broken links in them was mostly that I wanted to fix but it's not a big deal. While developing skillsaw I usually run the new release through a bunch of repos with the skillsaw.yaml deleted so I can see the impact of any changes including new rules

@cblecker

cblecker commented Jul 3, 2026

Copy link
Copy Markdown
Owner

fixing the broken links in #68

@cblecker cblecker closed this Jul 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants