Skip to content

fix: exclude skill JS files from Biome linting#67

Merged
cblecker merged 1 commit into
mainfrom
fix/biome-skill-js-ignore
Jul 3, 2026
Merged

fix: exclude skill JS files from Biome linting#67
cblecker merged 1 commit into
mainfrom
fix/biome-skill-js-ignore

Conversation

@cblecker

@cblecker cblecker commented Jul 3, 2026

Copy link
Copy Markdown
Owner

Summary

  • Adds biome.jsonc to exclude **/skills/**/*.js from Biome analysis
  • Fixes CodeRabbit false positive: "Illegal return statement outside of a function" on pr-review-toolkit/skills/review-pr/review-pr.js
  • Claude Code skill .js files are evaluated as function bodies where top-level return is valid, but Biome parses them as standalone modules

Test plan

  • Verify biome.jsonc is valid JSON
  • Confirm CodeRabbit no longer reports Biome syntax errors on PRs touching skill JS files

Claude Code skill .js files are evaluated as function bodies, so
top-level return statements are valid. Biome parses them as standalone
modules and flags the return as a syntax error, causing false positives
in CodeRabbit reviews.

Assisted-by: Claude:claude-opus-4-6
Copilot AI review requested due to automatic review settings July 3, 2026 19:20
@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@cblecker, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 41 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 8bc018a5-4ed6-410b-a750-190b576352c2

📥 Commits

Reviewing files that changed from the base of the PR and between 39a04cc and 3edf777.

📒 Files selected for processing (1)
  • biome.jsonc
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/biome-skill-js-ignore

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cblecker cblecker enabled auto-merge July 3, 2026 19:20
@cblecker cblecker merged commit 3867665 into main Jul 3, 2026
14 checks passed
@cblecker cblecker deleted the fix/biome-skill-js-ignore branch July 3, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a root-level biome.jsonc to exclude Claude Code skill JavaScript files (**/skills/**/*.js) from Biome analysis. The goal is to suppress a CodeRabbit/Biome false positive ("Illegal return statement outside of a function") on pr-review-toolkit/skills/review-pr/review-pr.js, which is a Claude Workflow script (evaluated as a function body where top-level return is valid) rather than a standalone module. This mirrors existing exclusion patterns already used for skill content in .skillsaw.yaml, .markdownlint-cli2.jsonc, and .coderabbit.yaml, though with a broader glob.

Changes:

  • Adds a new biome.jsonc at the repository root pinned to the Biome 2.0.6 schema.
  • Configures an exclusion so skill .js files are not linted by Biome.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread biome.jsonc
Comment on lines +4 to +6
"ignore": [
"**/skills/**/*.js"
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants