Update condo model report to include train test split and descriptives#165
Open
Damonamajor wants to merge 3 commits into
Open
Conversation
Damonamajor
requested review from
TimCookCountyDS,
jeancochrane and
wrridgeway
as code owners
wrridgeway
approved these changes
Jul 8, 2026
wrridgeway
left a comment
wrridgeway
left a comment
Member
There was a problem hiding this comment.
1 tiny change and this is good to go. Sorry it took so long to review! We should probably make the same change in the res repo, too.
Comment on lines
+54
to
+57
| mutate(across(c( | ||
| rmse, starts_with("sale_fmv_"), | ||
| starts_with("estimate_fmv_") | ||
| ), scales::dollar)) %>% |
Member
There was a problem hiding this comment.
We should add MAE to the columns formatted with dollar signs, since it's in the same units as our target variable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a companion PR which adds in the train_test splits for the following res model PR.
ccao-data/model-res-avm#504
Proof of run:
https://us-east-1.console.aws.amazon.com/cloudwatch/home?region=us-east-1#logsV2:log-groups/log-group/%2Faws%2Fbatch%2Fjob/log-events/z_ci_148-update-condo-model-report-to-include-train-test-split-and-descriptives_ccao-data-model-condo-avm%2Fdefault%2F7451618341704a5ca461a01764c436a1
Report:
https://us-east-1.console.aws.amazon.com/s3/object/ccao-model-results-us-east-1?region=us-east-1&prefix=report/year%3D2026/report_type%3Dperformance/2026-06-29-kind-yuxin.html