[Do not merge] Update desk review for MyDec sales#523
Open
Damonamajor wants to merge 6 commits into
Open
Conversation
Damonamajor
commented
Jun 25, 2026
| ") | ||
| ) | ||
|
|
||
| assessment_pin <- assessment_pin %>% |
Contributor
Author
There was a problem hiding this comment.
I don't know why a 1:1 join for PINs wouldn't work, and it didn't provide a warning, but just wanted to flag it.
Damonamajor
commented
Jun 25, 2026
| params$assessment$year, | ||
| str_replace(town_convert(town), " ", "_"), | ||
| "Initial_Model_Values.xlsx", | ||
| "Initial_Model_Values_Updated_Sales.xlsx", |
Contributor
Author
There was a problem hiding this comment.
Updated names for spreadsheets.
Damonamajor
commented
Jun 25, 2026
| # Pull the PIN-level assessment data, which contains all the fields needed to | ||
| # create the review spreadsheets | ||
| # Sale columns are pulled from a separate run with the missing sales | ||
| MISSING_SALES_RUN_ID <- "2026-06-16-charming-claire" |
Contributor
Author
There was a problem hiding this comment.
Parametized out is not really needed but better for tracking.
Damonamajor
marked this pull request as ready for review
June 25, 2026 21:40
Damonamajor
requested review from
TimCookCountyDS,
jeancochrane and
wrridgeway
as code owners
June 25, 2026 21:40
Contributor
Author
|
Example include missing sale for |
jeancochrane
changed the title
jeancochrane
force-pushed
the
update-desk-review-for-missing-sales
branch
from
June 25, 2026 22:05
f3ec050 to
89a4367
Compare
…o-data/model-res-avm into update-desk-review-for-missing-sales
jeancochrane
changed the title
jeancochrane
approved these changes
Jun 26, 2026
jeancochrane
left a comment
jeancochrane
left a comment
Member
There was a problem hiding this comment.
Looks great, thank you! As a reminder, we're not planning to merge this PR; instead, we'll leave it open until the MyDec sales have made it into iasWorld, then we'll close this PR without merging it since it won't be relevant anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the missing sales from
2026-06-16-charming-claireto our desk review output. It keeps all non-sale attributes from the previous run.Example include missing sale for
PIN:16293010290000
Doc_No: 2510014130