Use composite steps action instead of docker action; tidy ups.

Author: siong-chin

.github/workflows/status_check.yml

@@ -2,10 +2,16 @@ name: Run precommit checks on self
 on: pull_request
 jobs:
   precommit-check:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v2
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
-      - uses: ccdc-opensource/commit-hooks@precommit_action
+      - uses: actions/setup-python@v2
+        with:
+          python-version: "3.7"
+      - uses: ccdc-opensource/commit-hooks@composite_steps

Dockerfile

@@ -1,7 +1,7 @@
 This repository contains files that can be used as a github action and local
 git hooks.
 
-It does a few checks on source codes to ensure compliance with some general
+It does a few checks on source code to ensure compliance with some general
 CCDC coding standard.
 
 The commit will be flagged if it includes certain text files with:
@@ -31,13 +31,19 @@ on:
     branches: [ main ]
 jobs:
   Pull-request-files-check:
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
+    strategy:
+      matrix:
+        os: [ ubuntu-latest, macos-latest, windows-latest]
     steps:
       - uses: actions/checkout@v2
         with:
           ref: ${{ github.head_ref }}
           fetch-depth: 0
-      - uses: ccdc-opensource/commit-hooks@v1
+      - uses: actions/setup-python@v2
+        with:
+          python-version: "3.7"
+      - uses: ccdc-opensource/commit-hooks@v2
 ```
 
 # commit-hooks

README.md

@@ -2,8 +2,10 @@ name: CCDC File Checks
 author: CCDC
 description: Check changed files for compliance
 runs:
-  using: "docker"
-  image: "Dockerfile"
+  using: "composite"
+  steps:
+    - run: python3 $GITHUB_ACTION_PATH/main.py
+      shell: bash
 branding:
   icon: 'check-square'
   color: 'green'

action.yml

@@ -18,7 +18,7 @@
 # Absolute file size limit (in MB) - it's 100MB on github.com
 HARD_SIZE_THRESHOLD = 99.0
 # Internal file size limit (in MB) - allow if commit message includes marker
-SOFT_SIZE_THRESHOLD = 60.0
+SOFT_SIZE_THRESHOLD = 5.0
 # Large file marker in commit message
 LARGE_FILE_MARKER = 'LARGE_FILE'
 # Check file content if it has these extensions
@@ -102,7 +102,14 @@ def get_branch():
 
 
 def get_sha():
-    '''Get the commit sha'''
+    '''Get the commit sha
+
+    The sha of the branch we are interested in, ie. the tip of the branch that
+    is pushed or to be merged to main.
+
+    GITHUB_SHA cannot be used because in a pull request it gives the sha of the
+    fake merge commit.
+    '''
     return _get_output(f'git rev-parse {get_branch()}')