Commit 052bb47
feat(tcp): source TCP buffer defaults from tcp.rmem/wmem.default (autotune step 5)
Fifth phase of the Tier-3 buffer auto-tuning plan
(docs/refactor/tcp_buffer_autotuning.md §2/§7/§10 step 5). Wire a TCP
socket's unset receive-window seed and send-buffer floor to the
tcp.rmem.default / tcp.wmem.default sysctls (Linux tcp_rmem[1] /
tcp_wmem[1]), giving the step-1 .default knobs live consumers and making
the TCP starting buffers operator-tunable.
Deliberately conservative: rather than adopting Linux's small initial
values (which would make auto-tuning immediately visible but change every
unset-buffer connection's start point), this keeps PyTCP's conservative
65535 / 212992 defaults and only re-sources them. The shipped knob values
equal the old constants, so there is ZERO behaviour change and no test
churn; an operator who wants Linux-style small-start-plus-autotune sets
'sysctl tcp.wmem.default=16384' with no code change.
Mechanism — a template-method seam on the base socket:
- socket._default_sndbuf() / _default_rcvbuf() return the generic
SOCKET__SO_{SND,RCV}BUF__DEFAULT (Linux net.core.{w,r}mem_default), the
datagram default; _effective_sndbuf() / _effective_rcvbuf() now call
through them.
- TcpSocket overrides both to return tcp__constants.TCP__WMEM__DEFAULT /
TCP__RMEM__DEFAULT via qualified module access (live sysctl value).
The TcpSession rcv_wnd_max seed already reads _effective_rcvbuf(), so it
picks up tcp.rmem.default automatically; datagram sockets keep the
net.core stand-ins (matching Linux, where datagram and TCP defaults are
distinct sysctls).
Tests-first: test__tcp__session__buffer_defaults.py (5 cases — rcv/snd
defaults keep 65535/212992, operator override of each raises the
seed/floor, datagram sockets unaffected by the TCP knobs). RED pre-impl:
the two operator-override cases fail (seed/floor hardcoded to the
SOCKET__ constants); the three regression guards pass pre- and post-impl.
Plan §2/§7/§10 step 5 marked done (revised to the conservative decision).
Reference: RFC 9293 §3.8.6 (receive window management).
Reference: RFC 9293 §3.9 (SEND — send-buffer flow control).
Reference: Linux net.ipv4.tcp_rmem[1] / tcp_wmem[1].
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>1 parent 098e02d commit 052bb47
4 files changed
Lines changed: 272 additions & 26 deletions
File tree
- docs/refactor
- packages/pytcp/pytcp
- runtime/socket
- tests/integration/protocols/tcp
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
350 | 350 | | |
351 | 351 | | |
352 | 352 | | |
353 | | - | |
354 | | - | |
355 | | - | |
356 | | - | |
357 | | - | |
358 | | - | |
359 | | - | |
| 353 | + | |
| 354 | + | |
| 355 | + | |
| 356 | + | |
| 357 | + | |
| 358 | + | |
| 359 | + | |
| 360 | + | |
| 361 | + | |
| 362 | + | |
| 363 | + | |
360 | 364 | | |
361 | 365 | | |
362 | 366 | | |
| |||
381 | 385 | | |
382 | 386 | | |
383 | 387 | | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
| 388 | + | |
| 389 | + | |
| 390 | + | |
| 391 | + | |
| 392 | + | |
| 393 | + | |
| 394 | + | |
| 395 | + | |
| 396 | + | |
| 397 | + | |
388 | 398 | | |
389 | 399 | | |
390 | 400 | | |
| |||
537 | 547 | | |
538 | 548 | | |
539 | 549 | | |
540 | | - | |
541 | | - | |
542 | | - | |
543 | | - | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
| 555 | + | |
| 556 | + | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
| 561 | + | |
| 562 | + | |
| 563 | + | |
| 564 | + | |
| 565 | + | |
| 566 | + | |
544 | 567 | | |
545 | 568 | | |
546 | 569 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1447 | 1447 | | |
1448 | 1448 | | |
1449 | 1449 | | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
1450 | 1472 | | |
1451 | 1473 | | |
1452 | 1474 | | |
1453 | 1475 | | |
1454 | | - | |
1455 | | - | |
1456 | | - | |
1457 | | - | |
1458 | | - | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
1459 | 1481 | | |
1460 | 1482 | | |
1461 | 1483 | | |
1462 | 1484 | | |
1463 | | - | |
| 1485 | + | |
1464 | 1486 | | |
1465 | 1487 | | |
1466 | 1488 | | |
| |||
1476 | 1498 | | |
1477 | 1499 | | |
1478 | 1500 | | |
1479 | | - | |
1480 | | - | |
1481 | | - | |
1482 | | - | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
1483 | 1506 | | |
1484 | 1507 | | |
1485 | | - | |
| 1508 | + | |
1486 | 1509 | | |
1487 | 1510 | | |
1488 | 1511 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
| 53 | + | |
53 | 54 | | |
54 | 55 | | |
55 | 56 | | |
| |||
286 | 287 | | |
287 | 288 | | |
288 | 289 | | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
289 | 313 | | |
290 | 314 | | |
291 | 315 | | |
| |||
Lines changed: 176 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
0 commit comments