Merge pull request #1 from ccofallen/feat/cross-platform-desktop-release

Release cross-platform Codex Pet Pause desktop apps

Author: ccofallen

.github/workflows/build-desktop.yml

@@ -0,0 +1,112 @@
+name: Build Desktop
+
+on:
+  push:
+    branches: [main]
+    tags: ["v*"]
+  pull_request:
+  workflow_dispatch:
+
+permissions:
+  contents: write
+
+jobs:
+  validate:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+      - run: npm ci
+      - run: npx playwright install --with-deps chromium
+      - run: npm run test:desktop-release-config
+      - run: npm run test:brand-assets
+      - run: npm run test:desktop-workflow
+      - run: npm run test:electron
+      - run: npm run test:release-artifacts
+      - run: npm run test:release-tag
+      - run: npm run test:packaged-resources
+      - run: npm run test:packaged-app
+      - run: npm run check:desktop-release-config
+      - run: npm run test:run
+      - run: npm run build
+      - run: npm run test:e2e
+      - name: Validate workflow syntax with actionlint
+        run: docker run --rm -v "$GITHUB_WORKSPACE:/workspace" -w /workspace rhysd/actionlint:1.7.12 .github/workflows/build-desktop.yml
+
+  package:
+    needs: validate
+    if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
+    strategy:
+      fail-fast: false
+      matrix:
+        include:
+          - id: mac-arm64
+            target: mac-arm64
+            os: macos-latest
+            command: npm run desktop:pack:mac -- --arm64
+            artifact: release/*-mac-arm64.dmg
+          - id: mac-x64
+            target: mac-x64
+            os: macos-latest
+            command: npm run desktop:pack:mac -- --x64
+            artifact: release/*-mac-x64.dmg
+          - id: windows-x64
+            target: windows-x64
+            os: windows-latest
+            command: npm run desktop:pack:win -- --x64
+            artifact: release/*-windows-x64.exe
+          - id: linux-x64
+            target: linux-x64
+            os: ubuntu-latest
+            command: npm run desktop:pack:linux -- --x64
+            artifact: |
+              release/*-linux-x64.AppImage
+              release/*-linux-x64.deb
+    runs-on: ${{ matrix.os }}
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+          cache: npm
+      - run: npm ci
+      - run: node scripts/verify-release-tag.mjs "${{ github.ref_name }}"
+      - run: ${{ matrix.command }}
+      - run: npm run desktop:smoke:packaged-app
+      - run: node scripts/verify-release-artifacts.mjs release --target ${{ matrix.target }}
+      - uses: actions/upload-artifact@v4
+        with:
+          name: ${{ matrix.id }}
+          path: ${{ matrix.artifact }}
+          if-no-files-found: error
+
+  release:
+    needs: package
+    if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v')
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 22
+      - run: node scripts/verify-release-tag.mjs "${{ github.ref_name }}"
+      - uses: actions/download-artifact@v4
+        with:
+          path: release-assets
+          merge-multiple: true
+      - run: node scripts/verify-release-artifacts.mjs release-assets
+      - name: Publish release assets
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: |
+          if gh release view "$GITHUB_REF_NAME"; then
+            gh release view "$GITHUB_REF_NAME" --json assets --jq '.assets[].name' | while IFS= read -r asset; do
+              gh release delete-asset "$GITHUB_REF_NAME" "$asset" --yes
+            done
+            gh release upload "$GITHUB_REF_NAME" release-assets/*
+          else
+            gh release create "$GITHUB_REF_NAME" release-assets/* --generate-notes --title "Codex Pet Pause $GITHUB_REF_NAME"
+          fi

.superpowers/sdd/2026-07-26-cross-platform-release-implementation/task-1-report.md

@@ -0,0 +1,150 @@
+# Task 1 Report: Establish the Release Contract
+
+## Result
+
+Implemented the desktop release-config validator, its behavioral tests, and the two requested npm scripts. The final package matrix was not added; that remains owned by Task 3.
+
+## TDD evidence
+
+### RED
+
+Command:
+
+```bash
+node --test scripts/verify-desktop-release-config.test.mjs
+```
+
+Output:
+
+```text
+TAP version 13
+# Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/cc/Documents/Codex/codex-pet-pause-desktop/.worktrees/cross-platform-release/scripts/verify-desktop-release-config.mjs' imported from /Users/cc/Documents/Codex/codex-pet-pause-desktop/.worktrees/cross-platform-release/scripts/verify-desktop-release-config.test.mjs
+# Subtest: scripts/verify-desktop-release-config.test.mjs
+not ok 1 - scripts/verify-desktop-release-config.test.mjs
+1..1
+# tests 1
+# pass 0
+# fail 1
+```
+
+The test failed because the contract module did not exist, as required for the RED step.
+
+### GREEN
+
+Command:
+
+```bash
+npm run test:desktop-release-config
+```
+
+Output:
+
+```text
+> codex-pet-pause@0.2.0 test:desktop-release-config
+> node --test scripts/verify-desktop-release-config.test.mjs
+
+TAP version 13
+# Subtest: accepts the approved desktop release contract
+ok 1 - accepts the approved desktop release contract
+# Subtest: rejects an identity, target, or icon regression
+ok 2 - rejects an identity, target, or icon regression
+1..2
+# tests 2
+# pass 2
+# fail 0
+```
+
+## Files
+
+- `scripts/verify-desktop-release-config.mjs`: Exports `verifyDesktopReleaseConfig(packageJson, fileExists)`, validates the approved identity, platform targets, and icon existence, and provides the standalone `check:desktop-release-config` entry point.
+- `scripts/verify-desktop-release-config.test.mjs`: Covers acceptance of the approved contract and rejection of identity, target, and icon regressions.
+- `package.json`: Adds `test:desktop-release-config` and `check:desktop-release-config`.
+
+## Self-review
+
+- The implementation follows the exact validator shape and values from the task brief.
+- The injected `fileExists` function keeps the validator deterministic and directly testable.
+- Missing target entries and missing architecture entries produce human-readable failures rather than throwing.
+- No final Electron Builder package matrix or generated icon assets were added.
+
+## Concerns
+
+- `check:desktop-release-config` is expected to fail in this task state because `package.json` does not yet contain the final macOS, Windows, and Linux target configuration and the required icon assets are not present. Those changes belong to later release tasks.
+- Artifact-name templates are present in the behavioral fixture but are not validated by the prescribed validator implementation.
+
+## Fix round 1 evidence
+
+### RED mutations
+
+Added mutations for wrong configured native icon paths with `fileExists` returning `true`, plus extra `zip`, `nsis-web`, and `snap` targets. Before the validator changes:
+
+```bash
+node --test scripts/verify-desktop-release-config.test.mjs
+```
+
+```text
+TAP version 13
+# Subtest: accepts the approved desktop release contract
+ok 1 - accepts the approved desktop release contract
+# Subtest: rejects an identity, target, or icon regression
+ok 2 - rejects an identity, target, or icon regression
+# Subtest: rejects wrong configured native icon paths even when expected files exist
+not ok 3 - rejects wrong configured native icon paths even when expected files exist
+# Subtest: rejects unintended extra target formats on every platform
+not ok 4 - rejects unintended extra target formats on every platform
+1..4
+# tests 4
+# pass 2
+# fail 2
+```
+
+### GREEN focused test
+
+```bash
+npm run test:desktop-release-config
+```
+
+```text
+TAP version 13
+# Subtest: accepts the approved desktop release contract
+ok 1 - accepts the approved desktop release contract
+# Subtest: rejects an identity, target, or icon regression
+ok 2 - rejects an identity, target, or icon regression
+# Subtest: rejects wrong configured native icon paths even when expected files exist
+ok 3 - rejects wrong configured native icon paths even when expected files exist
+# Subtest: rejects unintended extra target formats on every platform
+ok 4 - rejects unintended extra target formats on every platform
+1..4
+# tests 4
+# pass 4
+# fail 0
+```
+
+### Direct check
+
+```bash
+npm run check:desktop-release-config
+```
+
+Expected current-package failure (exit code 1):
+
+```text
+Error: macOS targets must be exactly dmg
+macOS DMG must target arm64 and x64
+Windows targets must be exactly nsis
+Windows NSIS must target x64
+Linux targets must be exactly AppImage and deb
+Linux AppImage must target x64
+Linux DEB must target x64
+macOS icon must be configured as build/icons/icon.icns
+macOS icon is missing: build/icons/icon.icns
+Windows icon must be configured as build/icons/icon.ico
+Windows icon is missing: build/icons/icon.ico
+Linux icon must be configured as build/icons/png
+Linux icon is missing: build/icons/png
+```
+
+## Fix round 1 changes
+
+- Native icon validation now compares each configured platform icon with its expected native path before checking file existence.
+- Target validation now rejects any platform target-name set other than macOS `dmg`, Windows `nsis`, and Linux `AppImage` plus `deb`, while retaining the required architecture checks.