start of ION select (and other new selections)#1159
Open
nwmoriarty wants to merge 1 commit into
Open
Conversation
Contributor
|
looks good to me if tests pass. Also suggest adding a test case to cctbx_project/iotbx/pdb/tst_atom_selection.py |
Contributor
Author
|
Did have a test but didn't choice the correct commit. All should be well.
Cheers
Nigel
…---
Nigel W. Moriarty
Building 92-4-431M1, Molecular Biophysics and Integrated Bioimaging
Lawrence Berkeley National Laboratory
Berkeley, CA 94720-8235
Email : ***@***.***
Web : CCI.LBL.gov
ORCID : orcid.org/0000-0001-8857-9464
On Mon, May 11, 2026 at 2:00 PM olegsobolev ***@***.***> wrote:
*olegsobolev* left a comment (cctbx/cctbx_project#1159)
<#1159 (comment)>
looks good to me if tests pass. Also suggest adding a test case to
cctbx_project/iotbx/pdb/tst_atom_selection.py
—
Reply to this email directly, view it on GitHub
<#1159 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHYQPDJUYXWVPTIKBENH4342I5ODAVCNFSM6AAAAACYZOUDK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DIMRVGE2DMNBZHA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.