refactor 'account' tests#182
Open
danieleades wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
my intention is to roll this out to the other tests as well |
danieleades
force-pushed
the
tests/refactor/account
branch
from
42661a0 to
0c40279
Compare
danieleades
force-pushed
the
tests/refactor/account
branch
from
0c40279 to
4ae5545
Compare
Contributor
Author
|
i'll mark this a draft for now. I want to see how well this generalises to the other tests before committing to the approach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR is derived from #180 , but i think it makes sense as an incremental improvement.
this PR
The second one is the most important, since this was adding an unnecessary constraint on the implementation (and forcing you to use BTreeMaps despite not actually needing a sorted heap).