fix: guard against sending empty symbol in isolated margin

Author: taobig

v2/margin_service.go

@@ -242,12 +242,11 @@ func (s *MarginBorrowRepayService) Do(ctx context.Context, opts ...RequestOption
 	m := params{
 		"asset":      s.asset,
 		"isIsolated": s.isIsolated,
-		//"symbol":     s.symbol,
-		"amount": s.amount,
-		"type":   string(s._type),
+		"amount":     s.amount,
+		"type":       string(s._type),
 	}
-	if s.isIsolated {
-		m["symbol"] = s.symbol // set symbol param only when isIsolated is true
+	if s.isIsolated && s.symbol != "" {
+		m["symbol"] = s.symbol // Only set symbol param when isIsolated is true
 	}
 	r.setFormParams(m)
 	res = new(TransactionResponse)
@@ -330,13 +329,6 @@ func (s *ListMarginBorrowRepayService) Do(ctx context.Context, opts ...RequestOp
 		secType:  secTypeSigned,
 	}
 	m := params{
-		//"asset":          s.asset,
-		//"isolatedSymbol": s.isolatedSymbol,
-		//"txId":           s.txId,
-		//"startTime":      s.startTime,
-		//"endTime":        s.endTime,
-		//"current":        s.current,
-		//"size":           s.size,
 		"type": string(s._type),
 	}
 	r.setParams(m)

v2/margin_service_test.go

@@ -106,8 +106,7 @@ func (s *marginTestSuite) TestBorrowRepayBorrow() {
 			"asset":      asset,
 			"amount":     amount,
 			"isIsolated": false,
-			//"symbol":     "",
-			"type": string(_type),
+			"type":       string(_type),
 		})
 		s.assertRequestEqual(e, r)
 	})
@@ -137,8 +136,7 @@ func (s *marginTestSuite) TestBorrowRepayRepay() {
 			"asset":      asset,
 			"amount":     amount,
 			"isIsolated": false,
-			//"symbol":     "",
-			"type": string(_type),
+			"type":       string(_type),
 		})
 		s.assertRequestEqual(e, r)
 	})
@@ -154,6 +152,72 @@ func (s *marginTestSuite) TestBorrowRepayRepay() {
 	s.assertTransactionResponseEqual(e, res)
 }
 
+func (s *marginTestSuite) TestBorrowRepayBorrowIsolated() {
+	data := []byte(`{
+		"tranId": 100000001
+	}`)
+	s.mockDo(data, nil)
+	defer s.assertDo()
+	asset := "BTC"
+	amount := "1.000"
+	symbol := "BTCUSDT"
+	_type := MarginAccountBorrow
+	s.assertReq(func(r *request) {
+		e := newSignedRequest().setFormParams(params{
+			"asset":      asset,
+			"amount":     amount,
+			"isIsolated": true,
+			"symbol":     symbol,
+			"type":       string(_type),
+		})
+		s.assertRequestEqual(e, r)
+	})
+	res, err := s.client.NewMarginBorrowRepayService().
+		Asset(asset).
+		Amount(amount).
+		IsIsolated(true).
+		Symbol(symbol).
+		Type(_type).
+		Do(newContext())
+	s.r().NoError(err)
+	e := &TransactionResponse{
+		TranID: 100000001,
+	}
+	s.assertTransactionResponseEqual(e, res)
+}
+
+func (s *marginTestSuite) TestBorrowRepayBorrowIsolatedWithoutSymbol() {
+	data := []byte(`{
+		"tranId": 100000001
+	}`)
+	s.mockDo(data, nil)
+	defer s.assertDo()
+	asset := "BTC"
+	amount := "1.000"
+	_type := MarginAccountBorrow
+	s.assertReq(func(r *request) {
+		e := newSignedRequest().setFormParams(params{
+			"asset":      asset,
+			"amount":     amount,
+			"isIsolated": true,
+			"symbol":     "",
+			"type":       string(_type),
+		})
+		s.assertRequestEqual(e, r)
+	})
+	res, err := s.client.NewMarginBorrowRepayService().
+		Asset(asset).
+		Amount(amount).
+		IsIsolated(true).
+		Type(_type).
+		Do(newContext())
+	s.r().NoError(err)
+	e := &TransactionResponse{
+		TranID: 100000001,
+	}
+	s.assertTransactionResponseEqual(e, res)
+}
+
 func (s *marginTestSuite) TestListBorrowRepay() {
 	data := []byte(`{
 		  "rows": [