feat: Add sbe support#773
Open
pcriadoperez wants to merge 4 commits intomasterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for Simple Binary Encoding (SBE) protocol by adding generated SBE codec files for the Binance Spot API v3.1 schema. The generated code provides efficient binary serialization/deserialization for exchange messages.
Key Changes:
- Added generated SBE codec files for various message types (filters, responses, events)
- Added enumeration types for trading primitives
- Added documentation for SBE code generation process
Reviewed Changes
Copilot reviewed 36 out of 135 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| v2/sbe/spot_3_1/*.go | Generated SBE message codecs for exchange filters, order responses, events, and enumerations |
| v2/sbe/README.md | Documentation on generating SBE code from schema |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git clone https://github.com/aeron-io/simple-binary-encoding.gitto generate the types and decode from binarySteps for this PR:
Performance test:
to run: