Skip to content

Commit 557ff5b

Browse files
authored
Added on error handlers everywhere by kalinbas
2 parents 496fc9c + 5e02ca9 commit 557ff5b

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

node-binance-api.js

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,10 @@ let api = function Binance( options = {} ) {
188188
return cb( null, JSONbig.parse( body ) );
189189
}
190190

191-
const proxyRequest = ( opt, cb ) => request( addProxy( opt ), reqHandler( cb ) );
191+
const proxyRequest = ( opt, cb ) => {
192+
const req = request( addProxy( opt ), reqHandler( cb ) ).on('error', (err) => { cb( err, {} ) });
193+
return req;
194+
}
192195

193196
const reqObj = ( url, data = {}, method = 'GET', key ) => ( {
194197
url: url,
@@ -568,7 +571,7 @@ let api = function Binance( options = {} ) {
568571
} catch ( err ) {
569572
return reject( `promiseRequest error #${ response.statusCode }` );
570573
}
571-
} );
574+
} ).on( 'error', reject );
572575
} catch ( err ) {
573576
return reject( err );
574577
}
@@ -3151,7 +3154,7 @@ let api = function Binance( options = {} ) {
31513154
let result = {};
31523155
result[symbol] = JSON.parse( response.body ).price;
31533156
return resolve( result );
3154-
} );
3157+
} ).on( 'error', reject );
31553158
} );
31563159
}
31573160
request( addProxy( opt ), ( error, response, body ) => {
@@ -3160,7 +3163,7 @@ let api = function Binance( options = {} ) {
31603163
let result = {};
31613164
result[symbol] = JSON.parse( response.body ).price;
31623165
return callback( null, result );
3163-
} );
3166+
} ).on( 'error', callback );
31643167
},
31653168

31663169
/**
@@ -3183,14 +3186,14 @@ let api = function Binance( options = {} ) {
31833186
if ( error ) return reject( error );
31843187
if ( response.statusCode !== 200 ) return reject( response );
31853188
return resolve( priceData( JSON.parse( body ) ) );
3186-
} );
3189+
} ).on( 'error', reject );
31873190
} );
31883191
}
31893192
request( addProxy( opt ), ( error, response, body ) => {
31903193
if ( error ) return callback( error );
31913194
if ( response.statusCode !== 200 ) return callback( response );
31923195
return callback( null, priceData( JSON.parse( body ) ) );
3193-
} );
3196+
} ).on( 'error', callback );
31943197
},
31953198

31963199
/**
@@ -3213,15 +3216,15 @@ let api = function Binance( options = {} ) {
32133216
if ( response.statusCode !== 200 ) return reject( response );
32143217
const result = symbol ? JSON.parse( body ) : bookPriceData( JSON.parse( body ) );
32153218
return resolve( result );
3216-
} );
3219+
} ).on( 'error', reject );
32173220
} );
32183221
}
32193222
request( addProxy( opt ), ( error, response, body ) => {
32203223
if ( error ) return callback( error );
32213224
if ( response.statusCode !== 200 ) return callback( response );
32223225
const result = symbol ? JSON.parse( body ) : bookPriceData( JSON.parse( body ) );
32233226
return callback( null, result );
3224-
} );
3227+
} ).on( 'error', callback );
32253228
},
32263229

32273230
/**

0 commit comments

Comments
 (0)