Skip to content

Fix bad_alloc in verbose depth-map point-cloud export#1276

Open
Rheinwalt wants to merge 1 commit into
cdcseacave:developfrom
Rheinwalt:fix/dense-debug-ply-bad-alloc
Open

Fix bad_alloc in verbose depth-map point-cloud export#1276
Rheinwalt wants to merge 1 commit into
cdcseacave:developfrom
Rheinwalt:fix/dense-debug-ply-bad-alloc

Conversation

@Rheinwalt

Copy link
Copy Markdown

Fix a crash when running DensifyPointCloud with high-resolution depth maps and verbose logging enabled.

At -v 3, dense reconstruction exports per-depth-map debug PLY files. The preallocated PLY memory buffer size can overflow for large depth maps, producing a huge allocation request and aborting with std::bad_alloc.

This avoids the preallocated memory buffer for these debug point-cloud exports and uses the normal streamed PLY write path instead.

@cdcseacave

Copy link
Copy Markdown
Owner

thank you for spotting the bug, but PLY writing with buffer is much faster, instead of removing it can you fix the buffer size approximation pls?

@Rheinwalt
Rheinwalt force-pushed the fix/dense-debug-ply-bad-alloc branch from 349120e to 51212de Compare June 11, 2026 10:41
@Rheinwalt

Copy link
Copy Markdown
Author

Maybe you're right, no buffer was the lazy way out. However, with many threads and large images this can be pretty memory intensive still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants