Fix bad_alloc in verbose depth-map point-cloud export#1276
Open
Rheinwalt wants to merge 1 commit into
Open
Conversation
Owner
|
thank you for spotting the bug, but PLY writing with buffer is much faster, instead of removing it can you fix the buffer size approximation pls? |
Rheinwalt
force-pushed
the
fix/dense-debug-ply-bad-alloc
branch
from
June 11, 2026 10:41
349120e to
51212de
Compare
Author
|
Maybe you're right, no buffer was the lazy way out. However, with many threads and large images this can be pretty memory intensive still. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a crash when running DensifyPointCloud with high-resolution depth maps and verbose logging enabled.
At
-v 3, dense reconstruction exports per-depth-map debug PLY files. The preallocated PLY memory buffer size can overflow for large depth maps, producing a huge allocation request and aborting withstd::bad_alloc.This avoids the preallocated memory buffer for these debug point-cloud exports and uses the normal streamed PLY write path instead.