refine: robustify computation of refinement regularization scale#811
Open
adelpit wants to merge 1 commit into
Open
refine: robustify computation of refinement regularization scale#811adelpit wants to merge 1 commit into
adelpit wants to merge 1 commit into
Conversation
adelpit
commented
Apr 19, 2022
adelpit
commented
Contributor
- Use the masked depth map for the distance calculation so it will consider only the content inside the user-defined region of interest
- Use the average of the inverse depth (harmonic mean of depth) so that the metric scales with parallax rather than depth. This will also have the benefit of increase the influence of near structures
cdcseacave
reviewed
Dec 19, 2024
cdcseacave
left a comment
cdcseacave
left a comment
Owner
There was a problem hiding this comment.
Hi Andrew, these days I had time to look over this PR, and I like the idea you are suggesting. However I was wondering if instead of computing a RegularizationScale for the entire image, would be better (in the same spirit of the idea) to compute it per pixel (or per triangle) like:
pixelRegularizationScale = SQUARE(depth / cameraA.GetFocalLength())
Hopefully this will be not only better, but cheaper to compute as we will not need to compute ComputeAverageLocalInverseDepth()
Did you try this already?
cdcseacave
force-pushed
the
develop
branch
4 times, most recently
from
October 27, 2025 07:47
cd00cbe to
797b59e
Compare
cdcseacave
force-pushed
the
develop
branch
3 times, most recently
from
April 7, 2026 19:11
4831b8a to
6871967
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.