style: ruff format + drop unused import in pipeline_install_rust

Author: cdeust

mcp_server/infrastructure/pipeline_discovery.py

@@ -57,7 +57,9 @@
 
 # Where the silent installer clones and builds the upstream source.
 # Living next to other methodology artefacts means cleanup is one rm -rf.
-_INSTALL_SRC_DIR = Path.home() / ".claude" / "methodology" / "src" / "automatised-pipeline"
+_INSTALL_SRC_DIR = (
+    Path.home() / ".claude" / "methodology" / "src" / "automatised-pipeline"
+)
 _INSTALL_BIN_DIR = Path.home() / ".claude" / "methodology" / "bin"
 _INSTALL_SYMLINK = _INSTALL_BIN_DIR / "mcp-server"
 
@@ -112,7 +114,11 @@ def ensure_pipeline_connection() -> dict:
         # may have rm-rf'd the install dir, deleted the symlink, or
         # moved the source repo. Stale entries silently break ingest;
         # purge them so the install path can re-run.
-        if configured_cmd and Path(configured_cmd).exists() and os.access(configured_cmd, os.X_OK):
+        if (
+            configured_cmd
+            and Path(configured_cmd).exists()
+            and os.access(configured_cmd, os.X_OK)
+        ):
             return {
                 "action": "already_configured",
                 "path": str(path),
@@ -126,7 +132,9 @@ def ensure_pipeline_connection() -> dict:
         try:
             write_json(path, existing)
         except Exception as exc:
-            logger.warning("Failed to purge stale codebase entry from %s: %s", path, exc)
+            logger.warning(
+                "Failed to purge stale codebase entry from %s: %s", path, exc
+            )
 
     # Auto-install path. If discovery fails, attempt a silent
     # git-clone + cargo build (and rustup bootstrap if cargo missing)

mcp_server/infrastructure/pipeline_install_release.py

@@ -36,7 +36,9 @@
 from pathlib import Path
 from typing import Optional
 
-_RELEASES_URL = "https://api.github.com/repos/cdeust/automatised-pipeline/releases/latest"
+_RELEASES_URL = (
+    "https://api.github.com/repos/cdeust/automatised-pipeline/releases/latest"
+)
 _REQUEST_TIMEOUT = 30  # seconds
 _DISABLE_ENV = "CORTEX_DISABLE_PREBUILT"
 
@@ -46,7 +48,12 @@ def _platform_tag() -> Optional[str]:
     sys = platform.system().lower()
     mach = platform.machine().lower()
     os_tag = {"darwin": "macos", "linux": "linux"}.get(sys)
-    arch_tag = {"x86_64": "x86_64", "amd64": "x86_64", "arm64": "aarch64", "aarch64": "aarch64"}.get(mach)
+    arch_tag = {
+        "x86_64": "x86_64",
+        "amd64": "x86_64",
+        "arm64": "aarch64",
+        "aarch64": "aarch64",
+    }.get(mach)
     if not os_tag or not arch_tag:
         return None
     return f"{os_tag}-{arch_tag}"
@@ -88,7 +95,9 @@ def _find_assets(release: dict, tag: str) -> Optional[tuple[str, str]]:
     return None
 
 
-def _verify_and_extract(tar_path: str, expected_sha: str, dest_dir: str) -> Optional[str]:
+def _verify_and_extract(
+    tar_path: str, expected_sha: str, dest_dir: str
+) -> Optional[str]:
     """Verify SHA256, extract ``ai-architect-mcp`` to dest_dir, return path.
 
     Refuses tar entries that escape dest_dir (path-traversal guard).
@@ -158,11 +167,17 @@ def try_install_prebuilt(symlink_dest: Path) -> dict:
         digest_text = sha_bytes.decode("utf-8", errors="replace").strip()
         expected_sha = digest_text.split()[0] if digest_text else ""
         if len(expected_sha) != 64:
-            return {"action": "prebuilt_unavailable", "detail": "malformed sha256 manifest"}
+            return {
+                "action": "prebuilt_unavailable",
+                "detail": "malformed sha256 manifest",
+            }
 
         binary = _verify_and_extract(str(tar_path), expected_sha, str(work))
         if not binary:
-            return {"action": "prebuilt_unavailable", "detail": "hash mismatch or no binary in archive"}
+            return {
+                "action": "prebuilt_unavailable",
+                "detail": "hash mismatch or no binary in archive",
+            }
 
         # Move the verified binary into the methodology bin dir under a
         # versioned name so subsequent fast-path installs don't clash.

mcp_server/infrastructure/pipeline_install_rust.py

@@ -27,7 +27,6 @@
 import os
 import shlex
 import shutil
-import subprocess
 import tempfile
 from pathlib import Path
 from typing import Optional
@@ -114,7 +113,11 @@ def install_rust_toolchain() -> dict:
     if not curl:
         return {"action": "rust_curl_missing"}
 
-    pin_disabled = os.environ.get(_DISABLE_HASH_PIN_ENV, "").strip() in {"0", "false", "no"}
+    pin_disabled = os.environ.get(_DISABLE_HASH_PIN_ENV, "").strip() in {
+        "0",
+        "false",
+        "no",
+    }
     pinned_hash = None if pin_disabled else _read_pinned_hash()
 
     if pinned_hash:
@@ -139,7 +142,16 @@ def _install_with_hash_pin(curl: str, pinned_hash: str) -> dict:
         tmp_path = tmp.name
     try:
         rc, tail = _run_quiet(
-            [curl, "--proto", "=https", "--tlsv1.2", "-sSf", "-o", tmp_path, _RUSTUP_URL],
+            [
+                curl,
+                "--proto",
+                "=https",
+                "--tlsv1.2",
+                "-sSf",
+                "-o",
+                tmp_path,
+                _RUSTUP_URL,
+            ],
             timeout=120,
         )
         if rc != 0:

mcp_server/infrastructure/pipeline_installer.py

@@ -74,7 +74,9 @@ def _is_ci_environment() -> bool:
     return any(os.environ.get(name) for name in _CI_ENV_VARS)
 
 
-def install_pipeline(force_rebuild: bool = False, git_url: Optional[str] = None) -> dict:
+def install_pipeline(
+    force_rebuild: bool = False, git_url: Optional[str] = None
+) -> dict:
     """Best-effort silent install of the upstream pipeline binary.
 
     Returns audit dict with one of these actions:
@@ -109,7 +111,9 @@ def _install_locked(force_rebuild: bool, git_url: Optional[str]) -> dict:
     # falls through to the source-build path below.
     if not force_rebuild:
         prebuilt = try_install_prebuilt(_INSTALL_SYMLINK)
-        if prebuilt.get("action") == "installed_prebuilt" and _binary_is_usable(_INSTALL_SYMLINK):
+        if prebuilt.get("action") == "installed_prebuilt" and _binary_is_usable(
+            _INSTALL_SYMLINK
+        ):
             return prebuilt
 
     cargo = resolve_cargo()
@@ -156,7 +160,9 @@ def _install_locked(force_rebuild: bool, git_url: Optional[str]) -> dict:
     return _swap_symlink(binary)
 
 
-def _ensure_source(src: Path, url: str, git: str, force_rebuild: bool) -> Optional[dict]:
+def _ensure_source(
+    src: Path, url: str, git: str, force_rebuild: bool
+) -> Optional[dict]:
     """Clone or refresh the source tree. Return None on success, or
     a structured failure dict."""
     # Validate any existing checkout. A half-cloned dir leaves
@@ -166,14 +172,19 @@ def _ensure_source(src: Path, url: str, git: str, force_rebuild: bool) -> Option
         try:
             _rmtree_quiet(src)
         except OSError as exc:
-            return {"action": "clone_failed", "detail": f"stale partial src cleanup: {exc}"}
+            return {
+                "action": "clone_failed",
+                "detail": f"stale partial src cleanup: {exc}",
+            }
 
     if not src.exists():
         # Clone into a .partial sibling, atomic-rename on success.
         partial = src.with_name(src.name + ".partial")
         if partial.exists():
             _rmtree_quiet(partial)
-        rc, tail = _run_quiet([git, "clone", "--depth=1", url, str(partial)], timeout=1800)
+        rc, tail = _run_quiet(
+            [git, "clone", "--depth=1", url, str(partial)], timeout=1800
+        )
         if rc != 0 or not (partial / "Cargo.toml").is_file():
             _rmtree_quiet(partial)
             return {"action": "clone_failed", "detail": tail}

tests_py/infrastructure/test_pipeline_discovery.py

@@ -147,17 +147,24 @@ def test_stale_codebase_entry_purged(self, tmp_path, monkeypatch):
         purged so the install path can re-run instead of silently
         breaking ingest_codebase."""
         config_path = tmp_path / "mcp-connections.json"
-        config_path.write_text(json.dumps({
-            "servers": {
-                "codebase": {"command": "/nonexistent/mcp", "args": []},
-                "other": {"command": "node", "args": ["/x.js"]},
-            }
-        }))
+        config_path.write_text(
+            json.dumps(
+                {
+                    "servers": {
+                        "codebase": {"command": "/nonexistent/mcp", "args": []},
+                        "other": {"command": "node", "args": ["/x.js"]},
+                    }
+                }
+            )
+        )
         monkeypatch.setattr(pipeline_discovery, "MCP_CONNECTIONS_PATH", config_path)
         # Simulate fresh discovery finding nothing (no install attempted
         # because we monkeypatch install_pipeline import).
-        monkeypatch.setattr(pipeline_discovery, "discover_pipeline_command", lambda: None)
+        monkeypatch.setattr(
+            pipeline_discovery, "discover_pipeline_command", lambda: None
+        )
         from mcp_server.infrastructure import pipeline_installer
+
         monkeypatch.setattr(
             pipeline_installer,
             "install_pipeline",
@@ -321,6 +328,7 @@ def test_missing_toolchain_returns_structured_failure(self, tmp_path, monkeypatc
             tmp_path / "nonexistent" / "mcp-server",
         )
         from mcp_server.infrastructure import pipeline_install_rust
+
         # Disable the GitHub-Releases fast-path so the missing-toolchain
         # branch is reachable.
         monkeypatch.setattr(
@@ -384,7 +392,9 @@ def test_prebuilt_unsupported_platform(self, monkeypatch):
         from mcp_server.infrastructure import pipeline_install_release
 
         monkeypatch.delenv("CORTEX_DISABLE_PREBUILT", raising=False)
-        monkeypatch.setattr(pipeline_install_release.platform, "system", lambda: "OpenBSD")
+        monkeypatch.setattr(
+            pipeline_install_release.platform, "system", lambda: "OpenBSD"
+        )
         result = pipeline_install_release.try_install_prebuilt(Path("/tmp/symlink"))
         assert result["action"] == "prebuilt_unsupported_platform"
 
@@ -432,7 +442,9 @@ def test_install_failure_in_ensure_does_not_crash(self, tmp_path, monkeypatch):
 
         config_path = tmp_path / "mcp-connections.json"
         monkeypatch.setattr(pipeline_discovery, "MCP_CONNECTIONS_PATH", config_path)
-        monkeypatch.setattr(pipeline_discovery, "discover_pipeline_command", lambda: None)
+        monkeypatch.setattr(
+            pipeline_discovery, "discover_pipeline_command", lambda: None
+        )
         monkeypatch.setattr(
             pipeline_installer,
             "install_pipeline",