increment 0 indexed data#41
Merged
Merged
Conversation
Merged
gerrycampion
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was unable to find an exact date for this:
row=int(df_row.name) + 1, # record number should start at 1, not 0existed on the initial PR 4 years ago my Nic cdisc-org/cdisc-rules-engine@ab4c1bd#diff-0c6c96e9a87adfdd09ce9ab54524123b7fdb805ef9614f044ad20c50b4396d8fI did find data: CORE-00003 for instance has 0 indexing, its results were made on february 2022. I am unable to find the exact time between Nic's PR on Jul 11, 2022 and February 2022. I did use the more recent results when converting to results.csv as many had old and new results so I do believe a lot of the results with 0 indexing were resolved. I managed to find some which were not and are included in this PR.
i also ran a script looking at results.csv for 0 as the record to also catch some exceptions that were missed by only date checking the files.
Also found a piece of data in CORE-000119 that should have been in CORE-000199. Moved this+