Skip to content

Commit 19ec15e

Browse files
committed
remove execution column and put exec fails in actual
1 parent 39ffafe commit 19ec15e

2 files changed

Lines changed: 4 additions & 6 deletions

File tree

.github/workflows/validate-published-rules.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ jobs:
9898
CORE_IDS_ARG="--core-ids ${{ inputs.core_ids }}"
9999
fi
100100
101-
# CORE_IDS_ARG="--core-ids CORE-000001 CORE-000002 CORE-000003 CORE-000004 CORE-000005 CORE-000006" # TODO: Remove this before merging to main
101+
CORE_IDS_ARG="--core-ids CORE-000001 CORE-000002 CORE-000003 CORE-000004 CORE-000005 CORE-000006 CORE-000132" # TODO: Remove this before merging to main
102102
103103
./venv/bin/python engine/scripts/validate_published_rules.py \
104104
--rules-root "$(pwd)/open-rules" \

scripts/validate_published_rules.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
import subprocess
2222
import sys
2323

24-
SUMMARY_HEADERS = ["Rule", "Type", "Number", "Execution", "Expected", "Actual", "Match"]
24+
SUMMARY_HEADERS = ["Rule", "Type", "Number", "Expected", "Actual", "Match"]
2525
CHECKMARK = "\u2705"
2626
CROSS = "\u274c"
2727

@@ -76,9 +76,8 @@ def _parse_case_result(line: str) -> dict:
7676
"Rule": d["rule"],
7777
"Type": d["type"],
7878
"Number": str(d["num"]),
79-
"Execution": CHECKMARK if exec_ok else CROSS,
8079
"Expected": CROSS if d.get("expected") == "" else str(d["expected"]),
81-
"Actual": str(d.get("actual", "")),
80+
"Actual": str(d.get("actual", "")) if exec_ok else CROSS,
8281
"Match": CHECKMARK if match_ok else CROSS,
8382
# Private fields used when generating failure detail
8483
"_exec_ok": exec_ok,
@@ -180,9 +179,8 @@ def _aggregate_row(
180179
"Rule": rule_id,
181180
"Type": "\u2014",
182181
"Number": "\u2014",
183-
"Execution": CHECKMARK if exec_ok else CROSS,
184182
"Expected": "\u2014",
185-
"Actual": "\u2014",
183+
"Actual": CHECKMARK if exec_ok else CROSS,
186184
"Match": "\u2014",
187185
}
188186
if exec_ok:

0 commit comments

Comments
 (0)