moved validation logic to python script

Author: alexfurmenkov

.github/workflows/validate-published-rules.yml

@@ -91,151 +91,11 @@ jobs:
         run: |
           chmod +x open-rules/.github/scripts/run_validation.sh
 
-          # Write the JSON-line parser once; called once per test case in the loop below
-          cat > /tmp/parse_case.py << 'PYEOF'
-          import sys, json, shlex
-          d = json.load(sys.stdin)
-          for k, v in [
-            ('CASE_RULE',   d['rule']),
-            ('CASE_TYPE',   d['type']),
-            ('CASE_NUM',    str(d['num'])),
-            ('EXEC_OK',     '\u2705' if d['exec'] else '\u274c'),
-            ('EXPECTED',    str(d.get('expected', ''))),
-            ('GOT',         str(d.get('got', ''))),
-            ('MATCH',       '\u2705' if d.get('match') else '\u274c'),
-            ('DIFF_FILE',   str(d.get('diff', ''))),
-            ('STDERR_FILE', str(d.get('stderr', ''))),
-          ]:
-            print(k + '=' + shlex.quote(v))
-          PYEOF
-
-          PYTHON_CMD="$(pwd)/venv/bin/python"
-          ENGINE_DIR="$(pwd)/engine"
-          RULES_ROOT="$(pwd)/open-rules"
-          PUBLISHED_DIR="$RULES_ROOT/Published"
-          SCRIPTS_DIR="$RULES_ROOT/.github/scripts"
-
-          SUMMARY_TABLE="$(pwd)/summary_table.md"
-          DETAIL_REPORT="$(pwd)/detail_report.md"
-
-          OVERALL_EXIT=0
-          RULE_PASS=0
-          RULE_FAIL=0
-
-          mapfile -t RULE_DIRS < <(find "$PUBLISHED_DIR" -mindepth 1 -maxdepth 1 -type d | sort)
-
-          if [ ${#RULE_DIRS[@]} -eq 0 ]; then
-            echo "::warning::No rule directories found under Published/"
-            exit 0
-          fi
-
-          echo "Found ${#RULE_DIRS[@]} rule(s) under Published/"
-
-          # -- Initialise summary table
-          {
-            echo "# Published Rules Validation — Summary"
-            echo ""
-            echo "| Rule | Type | Number | Execution | Expected | Got | Match |"
-            echo "|------|------|--------|-----------|----------|-----|-------|"
-          } > "$SUMMARY_TABLE"
-
-          # -- Initialise detail report
-          {
-            echo "# Published Rules Validation — Failure Details"
-            echo ""
-          } > "$DETAIL_REPORT"
-
-          for RULE_DIR in "${RULE_DIRS[@]}"; do
-            RULE_ID=$(basename "$RULE_DIR")
-
-            RULE_YML=$(find "$RULE_DIR" -maxdepth 1 -name "*.yml" | head -1)
-            if [ -z "$RULE_YML" ]; then
-              echo "::warning::Skipping $RULE_ID — no .yml file found"
-              continue
-            fi
-
-            echo "========================================"
-            echo " Validating $RULE_ID"
-            echo "========================================"
-
-            RULE_EXIT=0
-            ENGINE_DIR_OVERRIDE="$ENGINE_DIR" \
-            bash "$SCRIPTS_DIR/run_validation.sh" \
-              "Published/$RULE_ID" \
-              "$PYTHON_CMD" \
-              "$RULES_ROOT" \
-              || RULE_EXIT=$?
-
-            # -- Parse per-test-case results produced by run_validation.sh
-            CASE_RESULTS="$RULES_ROOT/case_results.jsonl"
-            RULE_ROW_FAILED=0
-
-            if [ -f "$CASE_RESULTS" ]; then
-              while IFS= read -r line; do
-                # Parse all fields in a single python3 call — script written once above
-                eval "$(echo "$line" | python3 /tmp/parse_case.py)"
-
-                echo "| $CASE_RULE | $CASE_TYPE | $CASE_NUM | $EXEC_OK | $EXPECTED | $GOT | $MATCH |" >> "$SUMMARY_TABLE"
-
-                # Collect detail only for failures
-                if [[ "$EXEC_OK" == "❌" || "$MATCH" == "❌" ]]; then
-                  RULE_ROW_FAILED=1
-                  {
-                    echo "## $CASE_RULE — $CASE_TYPE / $CASE_NUM"
-                    if [[ "$EXEC_OK" == "❌" ]]; then
-                      echo "**Execution failed.**"
-                      if [ -f "$STDERR_FILE" ]; then
-                        echo '```'
-                        cat "$STDERR_FILE"
-                        echo '```'
-                      fi
-                    else
-                      echo "**Expected:** $EXPECTED  **Got:** $GOT"
-                      if [ -n "$DIFF_FILE" ] && [ -f "$DIFF_FILE" ]; then
-                        echo '```diff'
-                        cat "$DIFF_FILE"
-                        echo '```'
-                      fi
-                    fi
-                    echo ""
-                  } >> "$DETAIL_REPORT"
-                fi
-              done < "$CASE_RESULTS"
-              rm -f "$CASE_RESULTS"
-            else
-              # write a single aggregate row
-              EXEC_OK=$( [ $RULE_EXIT -eq 0 ] && echo "✅" || echo "❌" )
-              echo "| $RULE_ID | — | — | $EXEC_OK | — | — | — |" >> "$SUMMARY_TABLE"
-              if [ $RULE_EXIT -ne 0 ]; then
-                RULE_ROW_FAILED=1
-                # Append whatever markdown run_validation.sh produced
-                if [ -f "$RULES_ROOT/validation_report.md" ]; then
-                  {
-                    echo "## $RULE_ID"
-                    cat "$RULES_ROOT/validation_report.md"
-                    echo ""
-                  } >> "$DETAIL_REPORT"
-                fi
-              fi
-            fi
-
-            rm -f "$RULES_ROOT/validation_report.md"
-
-            if [ $RULE_ROW_FAILED -eq 0 ] && [ $RULE_EXIT -eq 0 ]; then
-              RULE_PASS=$((RULE_PASS + 1))
-              echo "  → $RULE_ID: PASSED"
-            else
-              RULE_FAIL=$((RULE_FAIL + 1))
-              OVERALL_EXIT=1
-              echo "  → $RULE_ID: FAILED"
-            fi
-          done
-
-          # -- Insert totals line into summary table
-          TOTALS="**Total:** $((RULE_PASS + RULE_FAIL))  |  ✅ Passed: $RULE_PASS  |  ❌ Failed: $RULE_FAIL"
-          sed -i "2s|^|$TOTALS\n\n|" "$SUMMARY_TABLE"
-
-          exit $OVERALL_EXIT
+          ./venv/bin/python engine/scripts/validate_published_rules.py \
+            --rules-root "$(pwd)/open-rules" \
+            --engine-dir "$(pwd)/engine" \
+            --python-cmd "$(pwd)/venv/bin/python" \
+            --output-dir "$(pwd)"
 
       # -----------------------------------------------------------------------
       # 6. Upload both reports + raw results as artifacts