expanded condition to truncate reported issues (#1730)

* expanded condition to truncate reported issues

* fix test

---------

Co-authored-by: Samuel Johnson <96841389+SFJohnson24@users.noreply.github.com>

Author: alexfurmenkov

cdisc_rules_engine/rules_engine.py

@@ -195,9 +195,13 @@ def _update_total_errors_and_check_limit(
 
     def _truncate_dataset_errors(self, dataset_results, rule, dataset_metadata):
         for result in dataset_results:
-            if result.get("executionStatus") == "success":
+            if result.get("executionStatus") in [
+                ExecutionStatus.ISSUE_REPORTED.value,
+                ExecutionStatus.SUCCESS.value,
+            ]:
                 errors = result.get("errors", [])
                 if len(errors) > self.max_errors_per_rule:
+                    result["original_errors_len"] = len(errors)
                     result["errors"] = errors[: self.max_errors_per_rule]
                     logger.info(
                         f"Rule {rule.get('core_id')}: Truncated {len(errors)} errors to "

cdisc_rules_engine/services/reporting/sdtm_report_data.py

@@ -224,11 +224,14 @@ def get_summary_data(self) -> list[dict]:
                     result.get("errors")
                     and result.get("executionStatus") != ExecutionStatus.SKIPPED.value
                 ):
+                    issues = result.get("original_errors_len") or len(
+                        result.get("errors", [])
+                    )
                     summary_item = {
                         "dataset": dataset,
                         "core_id": validation_result.id,
                         "message": result.get("message"),
-                        "issues": len(result.get("errors")),
+                        "issues": issues,
                     }
                     summary_data.append(summary_item)
 

tests/QARegressionTests/test_Issues/test_CoreIssue1718.py

@@ -0,0 +1,60 @@
+import os
+import subprocess
+import pytest
+import json
+from conftest import get_python_executable
+
+
+@pytest.mark.regression
+class TestCoreIssue1718:
+    def test_max_issues(self):
+        # Run the command in the terminal
+        max_issues = 3
+        command = [
+            f"{get_python_executable()}",
+            "-m",
+            "core",
+            "validate",
+            "-s",
+            "sdtmig",
+            "-v",
+            "3-4",
+            "-d",
+            os.path.join(
+                "tests",
+                "resources",
+                "CoreIssue1718",
+            ),
+            "-r",
+            "CORE-000356",
+            "-ps",
+            "1",
+            "-of",
+            "json",
+            "-me",
+            f"{max_issues}",
+            "true",
+        ]
+        subprocess.run(command, check=True)
+
+        files = os.listdir()
+        json_files = [
+            file
+            for file in files
+            if file.startswith("CORE-Report-") and file.endswith(".json")
+        ]
+        json_report_path = sorted(json_files)[-1]
+        json_report = json.load(open(json_report_path))
+        assert {
+            "Conformance_Details",
+            "Dataset_Details",
+            "Issue_Summary",
+            "Issue_Details",
+            "Rules_Report",
+        }.issubset(json_report.keys())
+        assert json_report["Rules_Report"][0]["status"] == "ISSUE REPORTED"
+        assert json_report["Issue_Summary"][0]["issues"] == 74
+        assert len(json_report["Issue_Details"]) == max_issues
+
+        if os.path.exists(json_report_path):
+            os.remove(json_report_path)