date bug#1737
Merged
Merged
Conversation
Closed
RamilCDISC
approved these changes
May 28, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR adds an additional type check to the date is valid helper in check operators. This check for string dates successfully resolves the bug reported for the Rules in attached tickets. See attached reports for results in the PR description.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SEND354 and CG0620 produce a float cannot be iterated issue--this PR updates the catch in the beginning of date check to not only catch None but also catch non-strings as floats are getting passed this first line and causing the rules to fail to execute
CORE-Report-2026-05-18T08-54-41.xlsx
CORE-Report-2026-05-18T09-04-05.xlsx
result pre- and post- fix